Adds warning to publish descendants dialog when force re-publish is selected (15)#18410
Merged
iOvergaard merged 2 commits intov15/devfrom Feb 21, 2025
Merged
Conversation
iOvergaard
requested changes
Feb 21, 2025
...publishing/publish-with-descendants/modal/document-publish-with-descendants-modal.element.ts
Outdated
Show resolved
Hide resolved
...publishing/publish-with-descendants/modal/document-publish-with-descendants-modal.element.ts
Outdated
Show resolved
Hide resolved
iOvergaard
approved these changes
Feb 21, 2025
iOvergaard
deleted the
v15/improvement/add-warning-on-force-republish
branch
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
This is addition to #18270 tackling issue #13739
Description
It was brought to my attention that we should include a warning on the "force re-publish" option, just to avoid people getting into the habit of selecting this option when it's not necessary.
To Test: