Split force for publish descendants into separate options for publish unpublish and re-publish unedited (15) #18270
Merged
AndyButland merged 13 commits intov15/devfrom Feb 12, 2025
Conversation
AndyButland
added
status/needs-docs
Migaroez
reviewed
Feb 11, 2025
Contributor
Migaroez
left a comment
Migaroez
left a comment
There was a problem hiding this comment.
Left some comments on the code.
Test coverage seems mostly ok and the minimal update of the tests which is inline with converting the bool to enum in code makes me hopeful that we aren't breaking anything.
Still some manual testing left to do
...o.Tests.Integration/Umbraco.Infrastructure/Services/ContentPublishingServiceTests.Publish.cs
Outdated
Show resolved
Hide resolved
Migaroez
approved these changes
Feb 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Resolves: #13739
Description
This is the 15 equivalent of #18249. Please see that PR for description and testing notes.