Skip to content

Merge branch 'v15/dev' into v15/feature/tree-expansion

42be261
Select commit
Loading
Failed to load commit list.
Merged

Feature: Tree expansion state #18227

Merge branch 'v15/dev' into v15/feature/tree-expansion
42be261
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (v15/dev) failed Mar 19, 2025 in 33s

CodeScene PR Check

Quality Gate Failed

Gates Failed
Enforce advisory code health rules (2 files with Complex Method, Complex Conditional)

Gates Passed
3 Quality Gates Passed

See analysis details in CodeScene

Reason for failure
Enforce advisory code health rules Violations Code Health Impact
default-tree.element.ts 1 advisory rule 10.00 → 9.69 Suppress
tree-item-context-base.ts 1 advisory rule 9.05 → 8.77 Suppress

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method default-tree.element.ts: UmbDefaultTreeElement.updated
  • Complex Conditional tree-item-context-base.ts: UmbTreeItemContextBase.observeExpansion

Annotations

Check warning on line 120 in src/Umbraco.Web.UI.Client/src/packages/core/tree/default/default-tree.element.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v15/dev)

❌ New issue: Complex Method

UmbDefaultTreeElement.updated has a cyclomatic complexity of 9, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 399 in src/Umbraco.Web.UI.Client/src/packages/core/tree/tree-item/tree-item-base/tree-item-context-base.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v15/dev)

❌ New issue: Complex Conditional

UmbTreeItemContextBase.observeExpansion has 1 complex conditionals with 2 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.