Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
8165dc3
implement tree expansion logic
madsrasmussen Jan 29, 2025
677d2ae
wip test example
madsrasmussen Jan 30, 2025
94105ac
Merge branch 'v15/dev' into v15/feature/tree-expansion
madsrasmussen Feb 24, 2025
78b53cd
Merge branch 'v15/dev' into v15/feature/tree-expansion
madsrasmussen Feb 25, 2025
3ef8f21
support complex expansion
madsrasmussen Feb 25, 2025
52479c1
extend entity
madsrasmussen Feb 25, 2025
c7813e0
extend with model
madsrasmussen Feb 25, 2025
7500a03
Merge branch 'v15/dev' into v15/feature/tree-expansion
madsrasmussen Mar 4, 2025
bdd65c0
Update tree-item-context.interface.ts
madsrasmussen Mar 4, 2025
a88cdce
use expansion model to observe open state
madsrasmussen Mar 4, 2025
1ac8c3b
clean up
madsrasmussen Mar 4, 2025
1e42ae2
fall back to tree context
madsrasmussen Mar 4, 2025
4591b51
Update default-tree.context.ts
madsrasmussen Mar 4, 2025
d2f3698
Update default-tree.context.ts
madsrasmussen Mar 4, 2025
e697740
Update default-tree.context.ts
madsrasmussen Mar 4, 2025
25fb01e
clean up
madsrasmussen Mar 4, 2025
626a186
Merge branch 'v15/dev' into v15/feature/tree-expansion
madsrasmussen Mar 5, 2025
3d8a3e9
simplify model and state
madsrasmussen Mar 5, 2025
e4a08d1
refactor to manager
madsrasmussen Mar 5, 2025
0e1254e
remove test data
madsrasmussen Mar 5, 2025
9900456
Update default-tree.context.ts
madsrasmussen Mar 5, 2025
7482248
rename
madsrasmussen Mar 5, 2025
06fe2f5
add get method
madsrasmussen Mar 5, 2025
15f39cc
rename to collapse
madsrasmussen Mar 5, 2025
bae0ff7
all collapse all method
madsrasmussen Mar 5, 2025
a623766
Merge branch 'v15/dev' into v15/feature/tree-expansion
madsrasmussen Mar 6, 2025
67dc5de
fix collapse logic
madsrasmussen Mar 6, 2025
c6c1644
Merge branch 'v15/dev' into v15/feature/tree-expansion
madsrasmussen Mar 7, 2025
f55ec82
add js docs
madsrasmussen Mar 7, 2025
7aec694
add tests for expansion manager
madsrasmussen Mar 7, 2025
4f091ae
do not load children if the item is already open
madsrasmussen Mar 7, 2025
a878186
Update tree-item-element-base.ts
madsrasmussen Mar 7, 2025
fab707c
config to expand tree root in pickers
madsrasmussen Mar 7, 2025
5d20dfb
expand tree root for duplicate to
madsrasmussen Mar 7, 2025
400670b
Update tree-expansion-manager.test.ts
madsrasmussen Mar 7, 2025
a5626a1
make methods async
madsrasmussen Mar 7, 2025
42be261
Merge branch 'v15/dev' into v15/feature/tree-expansion
nielslyngsoe Mar 19, 2025
b6aa63b
use array state
madsrasmussen Mar 20, 2025
8eabec2
add isExpanded helper
madsrasmussen Mar 20, 2025
5265769
refactor to use isExpanded helper
madsrasmussen Mar 20, 2025
9cc302f
fix type issues
madsrasmussen Mar 20, 2025
f966260
Merge branch 'v15/dev' into v15/feature/tree-expansion
nielslyngsoe Mar 21, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ import type { UmbTreeRepository } from '../data/tree-repository.interface.js';
import type { UmbTreeContext } from '../tree-context.interface.js';
import type { UmbTreeRootItemsRequestArgs } from '../data/types.js';
import type { ManifestTree } from '../extensions/types.js';
import { UmbTreeExpansionManager } from '../expansion-manager/index.js';
import type { UmbTreeExpansionModel } from '../expansion-manager/types.js';
import { UMB_TREE_CONTEXT } from './default-tree.context-token.js';
import { type UmbActionEventContext, UMB_ACTION_EVENT_CONTEXT } from '@umbraco-cms/backoffice/action';
import { type ManifestRepository, umbExtensionsRegistry } from '@umbraco-cms/backoffice/extension-registry';
Expand Down Expand Up @@ -38,10 +40,14 @@ export class UmbDefaultTreeContext<
public filter?: (item: TreeItemType) => boolean = () => true;
public readonly selection = new UmbSelectionManager(this._host);
public readonly pagination = new UmbPaginationManager();
public readonly expansion = new UmbTreeExpansionManager(this._host);

#hideTreeRoot = new UmbBooleanState(false);
hideTreeRoot = this.#hideTreeRoot.asObservable();

#expandTreeRoot = new UmbBooleanState(undefined);
expandTreeRoot = this.#expandTreeRoot.asObservable();

#startNode = new UmbObjectState<UmbTreeStartNode | undefined>(undefined);
startNode = this.#startNode.asObservable();

Expand Down Expand Up @@ -156,6 +162,10 @@ export class UmbDefaultTreeContext<
if (data) {
this.#treeRoot.setValue(data);
this.pagination.setTotalItems(1);

if (this.getExpandTreeRoot()) {
this.#toggleTreeRootExpansion(true);
}
}
}

Expand Down Expand Up @@ -277,6 +287,56 @@ export class UmbDefaultTreeContext<
return this.#additionalRequestArgs.getValue();
}

/**
* Sets the expansion state
* @param {UmbTreeExpansionModel} data - The expansion state
* @returns {void}
* @memberof UmbDefaultTreeContext
*/
setExpansion(data: UmbTreeExpansionModel): void {
this.expansion.setExpansion(data);
}

/**
* Gets the expansion state
* @returns {UmbTreeExpansionModel} - The expansion state
* @memberof UmbDefaultTreeContext
*/
getExpansion(): UmbTreeExpansionModel {
return this.expansion.getExpansion();
}

/**
* Sets the expandTreeRoot config
* @param {boolean} expandTreeRoot - Whether to expand the tree root
* @memberof UmbDefaultTreeContext
*/
setExpandTreeRoot(expandTreeRoot: boolean) {
this.#expandTreeRoot.setValue(expandTreeRoot);
this.#toggleTreeRootExpansion(expandTreeRoot);
}

/**
* Gets the expandTreeRoot config
* @returns {boolean | undefined} - Whether to expand the tree root
* @memberof UmbDefaultTreeContext
*/
getExpandTreeRoot(): boolean | undefined {
return this.#expandTreeRoot.getValue();
}

#toggleTreeRootExpansion(expand: boolean) {
const treeRoot = this.#treeRoot.getValue();
if (!treeRoot) return;
const treeRootEntity = { entityType: treeRoot.entityType, unique: treeRoot.unique };

if (expand) {
this.expansion.expandItem(treeRootEntity);
} else {
this.expansion.collapseItem(treeRootEntity);
}
}

#resetTree() {
this.#treeRoot.setValue(undefined);
this.#rootItems.setValue([]);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
UmbTreeSelectionConfiguration,
UmbTreeStartNode,
} from '../types.js';
import type { UmbTreeExpansionModel } from '../expansion-manager/types.js';
import type { UmbDefaultTreeContext } from './default-tree.context.js';
import { UMB_TREE_CONTEXT } from './default-tree.context-token.js';
import type { PropertyValueMap } from '@umbraco-cms/backoffice/external/lit';
Expand All @@ -28,6 +29,9 @@
@property({ type: Boolean, attribute: false })
hideTreeRoot: boolean = false;

@property({ type: Boolean, attribute: false })
expandTreeRoot: boolean = false;

@property({ type: Object, attribute: false })
startNode?: UmbTreeStartNode;

Expand All @@ -40,6 +44,9 @@
@property({ attribute: false })
filter: (item: UmbTreeItemModelBase) => boolean = () => true;

@property({ attribute: false })
expansion: UmbTreeExpansionModel = [];

@state()
private _rootItems: UmbTreeItemModel[] = [];

Expand Down Expand Up @@ -92,23 +99,35 @@
this.#treeContext!.setHideTreeRoot(this.hideTreeRoot);
}

if (_changedProperties.has('expandTreeRoot')) {
this.#treeContext!.setExpandTreeRoot(this.expandTreeRoot);
}

if (_changedProperties.has('foldersOnly')) {
this.#treeContext!.setFoldersOnly(this.foldersOnly ?? false);
}

if (_changedProperties.has('selectableFilter')) {
this.#treeContext!.selectableFilter = this.selectableFilter;
}

if (_changedProperties.has('filter')) {
this.#treeContext!.filter = this.filter;
}

if (_changedProperties.has('expansion')) {
this.#treeContext!.setExpansion(this.expansion);
}

Check warning on line 120 in src/Umbraco.Web.UI.Client/src/packages/core/tree/default/default-tree.element.ts

View check run for this annotation

CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (v15/dev)

❌ New issue: Complex Method

UmbDefaultTreeElement.updated has a cyclomatic complexity of 9, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
}

getSelection() {
return this.#treeContext?.selection.getSelection();
}

getExpansion() {
return this.#treeContext?.expansion.getExpansion();
}

override render() {
return html` ${this.#renderTreeRoot()} ${this.#renderRootItems()}`;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ export class UmbDuplicateToModalElement extends UmbModalBaseElement<UmbDuplicate
alias=${this.data.treeAlias}
.props=${{
foldersOnly: this.data?.foldersOnly,
expandTreeRoot: true,
}}
@selection-change=${this.#onTreeSelectionChange}></umb-tree>
</uui-box>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ export class UmbMoveToEntityAction extends UmbEntityActionBase<MetaEntityActionM
data: {
treeAlias: this.args.meta.treeAlias,
foldersOnly: this.args.meta.foldersOnly,
expandTreeRoot: true,
pickableFilter: (treeItem) => treeItem.unique !== this.args.unique,
},
});
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export * from './tree-expansion-manager.js';
Original file line number Diff line number Diff line change
@@ -0,0 +1,107 @@
import { UmbTreeExpansionManager } from './tree-expansion-manager.js';
import { expect } from '@open-wc/testing';
import { Observable } from '@umbraco-cms/backoffice/external/rxjs';
import { customElement } from '@umbraco-cms/backoffice/external/lit';
import { UmbControllerHostElementMixin } from '@umbraco-cms/backoffice/controller-api';

@customElement('test-my-controller-host')
class UmbTestControllerHostElement extends UmbControllerHostElementMixin(HTMLElement) {}

describe('UmbTreeExpansionManager', () => {
let manager: UmbTreeExpansionManager;
const item = { entityType: 'test', unique: '123' };
const item2 = { entityType: 'test', unique: '456' };

beforeEach(() => {
const hostElement = new UmbTestControllerHostElement();
manager = new UmbTreeExpansionManager(hostElement);
});

describe('Public API', () => {
describe('properties', () => {
it('has an expansion property', () => {
expect(manager).to.have.property('expansion').to.be.an.instanceOf(Observable);
});
});

describe('methods', () => {
it('has an isExpanded method', () => {
expect(manager).to.have.property('isExpanded').that.is.a('function');
});

it('has a setExpansion method', () => {
expect(manager).to.have.property('setExpansion').that.is.a('function');
});

it('has a getExpansion method', () => {
expect(manager).to.have.property('getExpansion').that.is.a('function');
});

it('has a expandItem method', () => {
expect(manager).to.have.property('expandItem').that.is.a('function');
});

it('has a collapseItem method', () => {
expect(manager).to.have.property('collapseItem').that.is.a('function');
});

it('has a collapseAll method', () => {
expect(manager).to.have.property('collapseAll').that.is.a('function');
});
});
});

describe('isExpanded', () => {
it('checks if an item is expanded', (done) => {
manager.setExpansion([item]);
const isExpanded = manager.isExpanded(item);
expect(isExpanded).to.be.an.instanceOf(Observable);
manager.isExpanded(item).subscribe((value) => {
console.log('VALUE', value);
expect(value).to.be.true;
done();
});
});
});

describe('setExpansion', () => {
it('sets the expansion state', () => {
const expansion = [item];
manager.setExpansion(expansion);
expect(manager.getExpansion()).to.deep.equal(expansion);
});
});

describe('getExpansion', () => {
it('gets the expansion state', () => {
const expansion = [item];
manager.setExpansion(expansion);
expect(manager.getExpansion()).to.deep.equal(expansion);
});
});

describe('expandItem', () => {
it('expands an item', async () => {
await manager.expandItem(item);
expect(manager.getExpansion()).to.deep.equal([item]);
});
});

describe('collapseItem', () => {
it('collapses an item', async () => {
await manager.expandItem(item);
expect(manager.getExpansion()).to.deep.equal([item]);
manager.collapseItem(item);
expect(manager.getExpansion()).to.deep.equal([]);
});
});

describe('collapseAll', () => {
it('collapses all items', () => {
manager.setExpansion([item, item2]);
expect(manager.getExpansion()).to.deep.equal([item, item2]);
manager.collapseAll();
expect(manager.getExpansion()).to.deep.equal([]);
});
});
});
Original file line number Diff line number Diff line change
@@ -0,0 +1,81 @@
import type { UmbTreeExpansionModel } from './types.js';
import { UmbControllerBase } from '@umbraco-cms/backoffice/class-api';
import type { UmbEntityModel } from '@umbraco-cms/backoffice/entity';
import { UmbArrayState, type Observable } from '@umbraco-cms/backoffice/observable-api';

/**
* Manages the expansion state of a tree
* @exports
* @class UmbTreeExpansionManager
* @augments {UmbControllerBase}
*/
export class UmbTreeExpansionManager extends UmbControllerBase {
#expansion = new UmbArrayState<UmbEntityModel>([], (x) => x.unique);
expansion = this.#expansion.asObservable();

/**
* Checks if an entity is expanded
* @param {UmbEntityModel} entity The entity to check
* @param {string} entity.entityType The entity type
* @param {string} entity.unique The unique key
* @returns {Observable<boolean>} True if the entity is expanded
* @memberof UmbTreeExpansionManager
*/
isExpanded(entity: UmbEntityModel): Observable<boolean> {
return this.#expansion.asObservablePart((entries) =>
entries?.some((entry) => entry.entityType === entity.entityType && entry.unique === entity.unique),
);
}

/**
* Sets the expansion state
* @param {UmbTreeExpansionModel | undefined} expansion The expansion state
* @memberof UmbTreeExpansionManager
* @returns {void}
*/
setExpansion(expansion: UmbTreeExpansionModel): void {
this.#expansion.setValue(expansion);
}

/**
* Gets the expansion state
* @memberof UmbTreeExpansionManager
* @returns {UmbTreeExpansionModel} The expansion state
*/
getExpansion(): UmbTreeExpansionModel {
return this.#expansion.getValue();
}

/**
* Opens a child tree item
* @param {UmbEntityModel} entity The entity to open
* @param {string} entity.entityType The entity type
* @param {string} entity.unique The unique key
* @memberof UmbTreeExpansionManager
* @returns {Promise<void>}
*/
public async expandItem(entity: UmbEntityModel): Promise<void> {
this.#expansion.appendOne(entity);
}

/**
* Closes a child tree item
* @param {UmbEntityModel} entity The entity to close
* @param {string} entity.entityType The entity type
* @param {string} entity.unique The unique key
* @memberof UmbTreeExpansionManager
* @returns {Promise<void>}
*/
public async collapseItem(entity: UmbEntityModel): Promise<void> {
this.#expansion.filter((x) => x.entityType !== entity.entityType || x.unique !== entity.unique);
}

/**
* Closes all child tree items
* @memberof UmbTreeExpansionManager
* @returns {Promise<void>}
*/
public async collapseAll(): Promise<void> {
this.#expansion.setValue([]);
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
import type { UmbEntityModel } from '@umbraco-cms/backoffice/entity';

export type UmbTreeExpansionModel = Array<UmbEntityModel>;
Loading
Loading