Skip to content

Conversation

@arukiidou
Copy link
Contributor

@arukiidou arukiidou commented Sep 16, 2025

Test with Go 1.24, Go 1.25

similar to;

passed test: arukiidou#12

note

one slogtest added since Go 1.25, but still passed.

Go 1.25 will add another test case to testing/slogtest , but still passed.

"a Handler should not output nested groups if there are no attributes"

also upgrades golang.org/x/vuln to v1.1.4

bacause
https://github.com/arukiidou/zap/actions/runs/17769123099/job/50500165958#step:6:64

Run make vulncheck
cd tools && go install golang.org/x/vuln/cmd/govulncheck
go: downloading golang.org/x/vuln v1.1.3
go: downloading golang.org/x/telemetry v0.0.0-20240522233618-39ace7a40ae7
go: downloading golang.org/x/mod v0.19.0
go: downloading golang.org/x/tools v0.23.0
go: downloading golang.org/x/sync v0.7.0
# golang.org/x/tools/internal/tokeninternal
Error: ../../../../go/pkg/mod/golang.org/x/[email protected]/internal/tokeninternal/tokeninternal.go:64:9: invalid array length -delta * delta (constant -256 of type int64)
make: *** [Makefile:48: /home/runner/work/zap/zap//bin/govulncheck] Error 1
Error: Process completed with exit code 2.

@codecov
Copy link

codecov bot commented Sep 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.59%. Comparing base (07077a6) to head (0d82c8f).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1508   +/-   ##
=======================================
  Coverage   98.59%   98.59%           
=======================================
  Files          53       53           
  Lines        3565     3565           
=======================================
  Hits         3515     3515           
  Misses         42       42           
  Partials        8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@r-hang r-hang merged commit 4b9cea0 into uber-go:master Nov 12, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants