Update go.yml #12
Closed
Update go.yml #12
+20
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: junya koyama <[email protected]>
Signed-off-by: junya koyama <[email protected]>
arukiidou
force-pushed
the
ci/test-go-125
branch
from
1ded8b0 to
0d82c8f
Compare
r-hang
pushed a commit
to uber-go/zap
that referenced
this pull request
Nov 12, 2025
Test with Go 1.24, Go 1.25 similar to; - #1409 - #1464 passed test: arukiidou#12 ## note ### one slogtest added since Go 1.25, but still passed. Go 1.25 will add another test case to testing/slogtest , but still passed. ``` "a Handler should not output nested groups if there are no attributes" ``` ### also upgrades golang.org/x/vuln to v1.1.4 bacause https://github.com/arukiidou/zap/actions/runs/17769123099/job/50500165958#step:6:64 ``` Run make vulncheck cd tools && go install golang.org/x/vuln/cmd/govulncheck go: downloading golang.org/x/vuln v1.1.3 go: downloading golang.org/x/telemetry v0.0.0-20240522233618-39ace7a40ae7 go: downloading golang.org/x/mod v0.19.0 go: downloading golang.org/x/tools v0.23.0 go: downloading golang.org/x/sync v0.7.0 # golang.org/x/tools/internal/tokeninternal Error: ../../../../go/pkg/mod/golang.org/x/[email protected]/internal/tokeninternal/tokeninternal.go:64:9: invalid array length -delta * delta (constant -256 of type int64) make: *** [Makefile:48: /home/runner/work/zap/zap//bin/govulncheck] Error 1 Error: Process completed with exit code 2. ``` --------- Signed-off-by: junya koyama <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.