This repository was archived by the owner on Feb 1, 2022. It is now read-only.
Warn if version 4 of Bootstrap is detected #254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvrebert
added a commit
that referenced
this pull request
Mar 2, 2015
Warn if version 4 of Bootstrap is detected
Contributor
There was a problem hiding this comment.
Out of curiosity, was the choice to go with 'FUTURE…' because Bootlint will only support V3 long term or is planning for supporting both now just pre-mature optimization? Thanks 😃
Collaborator
Author
There was a problem hiding this comment.
Major versions of Bootstrap are not (fully) backward-compatible with each other, hence Bootstrap v4 will require a new version of Bootlint, whose message here will in turn mention "Bootstrap v5 or later". I suppose we could template this message if we want to be über-future-proof.
See also #168.
Contributor
There was a problem hiding this comment.
Makes sense. Thank you for the explanation. 😃
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a tweaked version of #250 with some minor fixes and many nitpicks applied.