Skip to content

fix: update rclcpp action api #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roni-kreinin merged 1 commit into from
Aug 9, 2022
Merged

fix: update rclcpp action api #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions turtlebot4_node/include/turtlebot4_node/action.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,9 +141,8 @@ class Turtlebot4Action
* @input future - Shared future with goal response
*/
void goal_response_callback(
std::shared_future<typename rclcpp_action::ClientGoalHandle<ActionT>::SharedPtr> future)
typename rclcpp_action::ClientGoalHandle<ActionT>::SharedPtr goal_handle)
{
auto goal_handle = future.get();
if (!goal_handle) {
RCLCPP_ERROR(nh_->get_logger(), "%s goal was rejected by server", action_.c_str());
} else {
Expand Down