fix: update rclcpp action api

[wep21]

Signed-off-by: Daisuke Nishimatsu [email protected]

Description

update rclcpp action api for humble/rolling
This api change was introduced by ros2/rclcpp#1311

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.
Provide instructions so we can reproduce. Also list any relevant details for your test configuration.

# Run this command
ros2 launch package launch.py

Checklist

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation

[wep21]

@roni-kreinin Could you create humble or rolling branch? I would like to change the base branch after the branch is created.

[roni-kreinin]

humble branch created. Will this change need to be applied to galactic too?

[wep21]

The old api is compatible, but is marked as deprecated even in galactic. https://github.com/ros2/rclcpp/blob/206e0fd4fefb9fcf69d42c03ffbefd347f110aae/rclcpp_action/include/rclcpp_action/client.hpp#L289-L299
It may be better to add the changes into galactic too.

[roni-kreinin]

Merging for galactic and will keep this API for humble.