Fix Compilation Issue for RTX 5090 GPUs with Compute Capability = 120 #6131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pports only version 2
|
The 110 branch shouldn't be deleted. If you can update the PR I'll close #6120 |
Done |
Jokeren
approved these changes
Mar 6, 2025
Jokeren
approved these changes
Mar 6, 2025
woct0rdho
pushed a commit
to woct0rdho/triton-windows
that referenced
this pull request
Mar 15, 2025
…triton-lang#6131) This PR addresses a compilation issue when targeting RTX 5090 GPUs with compute capability 120. Previously, the function getMMAVersionSafe would trigger an assertion failure for compute capabilities beyond 110. This update ensures that GPUs with compute capability of 120 fall under a valid MMA version category, preventing unnecessary assertion failures. Changes Updated the compute capability check in getMMAVersionSafe to handle GPUs with compute capability up to 129. Assigned MMA version {2} for these cases to maintain compatibility with customer's gpus only supporting version 2. Motivation Certain GPUs, including models from the NVIDIA 50 series, have a compute capability of 120, which was previously unhandled, causing compilation failures. This fix ensures compatibility with such GPUs. <!--- The core Triton is a small number of people, and we receive many PRs (thank you!). To help us review your code more quickly, **if you are a new contributor (less than 3 PRs merged) we ask that you complete the following tasks and include the filled-out checklist in your PR description.** Complete the following tasks before sending your PR, and replace `[ ]` with `[x]` to indicate you have done them. --> # New contributor declaration - [x] I am not making a trivial change, such as fixing a typo in a comment. - [x ] I have written a PR description following these [rules](https://cbea.ms/git-commit/#why-not-how). - [ ] I have run `pre-commit run --from-ref origin/main --to-ref HEAD`. - Select one of the following. - [ ] I have added tests. - `/test` for `lit` tests - `/unittest` for C++ tests - `/python/test` for end-to-end tests - [x] This PR does not need a test because `FILL THIS IN`. - Select one of the following. - [x] I have not added any `lit` tests. - [ ] The `lit` tests I have added follow these [best practices](https://mlir.llvm.org/getting_started/TestingGuide/#filecheck-best-practices), including the "tests should be minimal" section. (Usually running Python code and using the instructions it generates is not minimal.)
woct0rdho
pushed a commit
to woct0rdho/triton-windows
that referenced
this pull request
Apr 9, 2025
…triton-lang#6131) This PR addresses a compilation issue when targeting RTX 5090 GPUs with compute capability 120. Previously, the function getMMAVersionSafe would trigger an assertion failure for compute capabilities beyond 110. This update ensures that GPUs with compute capability of 120 fall under a valid MMA version category, preventing unnecessary assertion failures. Changes Updated the compute capability check in getMMAVersionSafe to handle GPUs with compute capability up to 129. Assigned MMA version {2} for these cases to maintain compatibility with customer's gpus only supporting version 2. Motivation Certain GPUs, including models from the NVIDIA 50 series, have a compute capability of 120, which was previously unhandled, causing compilation failures. This fix ensures compatibility with such GPUs. <!--- The core Triton is a small number of people, and we receive many PRs (thank you!). To help us review your code more quickly, **if you are a new contributor (less than 3 PRs merged) we ask that you complete the following tasks and include the filled-out checklist in your PR description.** Complete the following tasks before sending your PR, and replace `[ ]` with `[x]` to indicate you have done them. --> # New contributor declaration - [x] I am not making a trivial change, such as fixing a typo in a comment. - [x ] I have written a PR description following these [rules](https://cbea.ms/git-commit/#why-not-how). - [ ] I have run `pre-commit run --from-ref origin/main --to-ref HEAD`. - Select one of the following. - [ ] I have added tests. - `/test` for `lit` tests - `/unittest` for C++ tests - `/python/test` for end-to-end tests - [x] This PR does not need a test because `FILL THIS IN`. - Select one of the following. - [x] I have not added any `lit` tests. - [ ] The `lit` tests I have added follow these [best practices](https://mlir.llvm.org/getting_started/TestingGuide/#filecheck-best-practices), including the "tests should be minimal" section. (Usually running Python code and using the instructions it generates is not minimal.)
woct0rdho
pushed a commit
to woct0rdho/triton-windows
that referenced
this pull request
Apr 10, 2025
…triton-lang#6131) This PR addresses a compilation issue when targeting RTX 5090 GPUs with compute capability 120. Previously, the function getMMAVersionSafe would trigger an assertion failure for compute capabilities beyond 110. This update ensures that GPUs with compute capability of 120 fall under a valid MMA version category, preventing unnecessary assertion failures. Changes Updated the compute capability check in getMMAVersionSafe to handle GPUs with compute capability up to 129. Assigned MMA version {2} for these cases to maintain compatibility with customer's gpus only supporting version 2. Motivation Certain GPUs, including models from the NVIDIA 50 series, have a compute capability of 120, which was previously unhandled, causing compilation failures. This fix ensures compatibility with such GPUs. <!--- The core Triton is a small number of people, and we receive many PRs (thank you!). To help us review your code more quickly, **if you are a new contributor (less than 3 PRs merged) we ask that you complete the following tasks and include the filled-out checklist in your PR description.** Complete the following tasks before sending your PR, and replace `[ ]` with `[x]` to indicate you have done them. --> # New contributor declaration - [x] I am not making a trivial change, such as fixing a typo in a comment. - [x ] I have written a PR description following these [rules](https://cbea.ms/git-commit/#why-not-how). - [ ] I have run `pre-commit run --from-ref origin/main --to-ref HEAD`. - Select one of the following. - [ ] I have added tests. - `/test` for `lit` tests - `/unittest` for C++ tests - `/python/test` for end-to-end tests - [x] This PR does not need a test because `FILL THIS IN`. - Select one of the following. - [x] I have not added any `lit` tests. - [ ] The `lit` tests I have added follow these [best practices](https://mlir.llvm.org/getting_started/TestingGuide/#filecheck-best-practices), including the "tests should be minimal" section. (Usually running Python code and using the instructions it generates is not minimal.)
davidberard98
pushed a commit
to davidberard98/triton
that referenced
this pull request
May 8, 2025
…triton-lang#6131) This PR addresses a compilation issue when targeting RTX 5090 GPUs with compute capability 120. Previously, the function getMMAVersionSafe would trigger an assertion failure for compute capabilities beyond 110. This update ensures that GPUs with compute capability of 120 fall under a valid MMA version category, preventing unnecessary assertion failures. Changes Updated the compute capability check in getMMAVersionSafe to handle GPUs with compute capability up to 129. Assigned MMA version {2} for these cases to maintain compatibility with customer's gpus only supporting version 2. Motivation Certain GPUs, including models from the NVIDIA 50 series, have a compute capability of 120, which was previously unhandled, causing compilation failures. This fix ensures compatibility with such GPUs. <!--- The core Triton is a small number of people, and we receive many PRs (thank you!). To help us review your code more quickly, **if you are a new contributor (less than 3 PRs merged) we ask that you complete the following tasks and include the filled-out checklist in your PR description.** Complete the following tasks before sending your PR, and replace `[ ]` with `[x]` to indicate you have done them. --> # New contributor declaration - [x] I am not making a trivial change, such as fixing a typo in a comment. - [x ] I have written a PR description following these [rules](https://cbea.ms/git-commit/#why-not-how). - [ ] I have run `pre-commit run --from-ref origin/main --to-ref HEAD`. - Select one of the following. - [ ] I have added tests. - `/test` for `lit` tests - `/unittest` for C++ tests - `/python/test` for end-to-end tests - [x] This PR does not need a test because `FILL THIS IN`. - Select one of the following. - [x] I have not added any `lit` tests. - [ ] The `lit` tests I have added follow these [best practices](https://mlir.llvm.org/getting_started/TestingGuide/#filecheck-best-practices), including the "tests should be minimal" section. (Usually running Python code and using the instructions it generates is not minimal.)
atalman
pushed a commit
that referenced
this pull request
May 13, 2025
…ute Capability = 120 (#6131) (#6771) This PR addresses a compilation issue when targeting RTX 5090 GPUs with compute capability 120. Previously, the function getMMAVersionSafe would trigger an assertion failure for compute capabilities beyond 110. This update ensures that GPUs with compute capability of 120 fall under a valid MMA version category, preventing unnecessary assertion failures. Changes Updated the compute capability check in getMMAVersionSafe to handle GPUs with compute capability up to 129. Assigned MMA version {2} for these cases to maintain compatibility with customer's gpus only supporting version 2. Motivation Certain GPUs, including models from the NVIDIA 50 series, have a compute capability of 120, which was previously unhandled, causing compilation failures. This fix ensures compatibility with such GPUs. <!--- The core Triton is a small number of people, and we receive many PRs (thank you!). To help us review your code more quickly, **if you are a new contributor (less than 3 PRs merged) we ask that you complete the following tasks and include the filled-out checklist in your PR description.** Complete the following tasks before sending your PR, and replace `[ ]` with `[x]` to indicate you have done them. --> # New contributor declaration - [x] I am not making a trivial change, such as fixing a typo in a comment. - [x ] I have written a PR description following these [rules](https://cbea.ms/git-commit/#why-not-how). - [ ] I have run `pre-commit run --from-ref origin/main --to-ref HEAD`. - Select one of the following. - [ ] I have added tests. - `/test` for `lit` tests - `/unittest` for C++ tests - `/python/test` for end-to-end tests - [x] This PR does not need a test because `FILL THIS IN`. - Select one of the following. - [x] I have not added any `lit` tests. - [ ] The `lit` tests I have added follow these [best practices](https://mlir.llvm.org/getting_started/TestingGuide/#filecheck-best-practices), including the "tests should be minimal" section. (Usually running Python code and using the instructions it generates is not minimal.) <!--- The core Triton is a small number of people, and we receive many PRs (thank you!). To help us review your code more quickly, **if you are a new contributor (less than 3 PRs merged) we ask that you complete the following tasks and include the filled-out checklist in your PR description.** Complete the following tasks before sending your PR, and replace `[ ]` with `[x]` to indicate you have done them. --> # New contributor declaration - [ ] I am not making a trivial change, such as fixing a typo in a comment. - [ ] I have written a PR description following these [rules](https://cbea.ms/git-commit/#why-not-how). - [ ] I have run `pre-commit run --from-ref origin/main --to-ref HEAD`. - Select one of the following. - [ ] I have added tests. - `/test` for `lit` tests - `/unittest` for C++ tests - `/python/test` for end-to-end tests - [ ] This PR does not need a test because `FILL THIS IN`. - Select one of the following. - [ ] I have not added any `lit` tests. - [ ] The `lit` tests I have added follow these [best practices](https://mlir.llvm.org/getting_started/TestingGuide/#filecheck-best-practices), including the "tests should be minimal" section. (Usually running Python code and using the instructions it generates is not minimal.) Co-authored-by: Antonio Gómez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a compilation issue when targeting RTX 5090 GPUs with compute capability 120. Previously, the function getMMAVersionSafe would trigger an assertion failure for compute capabilities beyond 110. This update ensures that GPUs with compute capability of 120 fall under a valid MMA version category, preventing unnecessary assertion failures.
Changes
Updated the compute capability check in getMMAVersionSafe to handle GPUs with compute capability up to 129.
Assigned MMA version {2} for these cases to maintain compatibility with customer's gpus only supporting version 2.
Motivation
Certain GPUs, including models from the NVIDIA 50 series, have a compute capability of 120, which was previously unhandled, causing compilation failures. This fix ensures compatibility with such GPUs.
New contributor declaration
I am not making a trivial change, such as fixing a typo in a comment.
[x ] I have written a PR description following these
rules.
I have run
pre-commit run --from-ref origin/main --to-ref HEAD.Select one of the following.
/testforlittests/unittestfor C++ tests/python/testfor end-to-end testsFILL THIS IN.Select one of the following.
littests.littests I have added follow these best practices,including the "tests should be minimal" section. (Usually running Python code
and using the instructions it generates is not minimal.)