-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Description
This is cherry-picking issue for release 3.3.1 of triton
Release Cherry-Pick Criteria
After branch cut, we approach finalizing the release branch with clear criteria on what cherry picks are allowed in. Note: a cherry pick is a process to land a PR in the release branch after branch cut. These are typically limited to ensure that the team has sufficient time to complete a thorough round of testing on a stable code base.
- Regression fixes - that address functional/performance regression against the most recent release (e.g. 3.3.0 for 3.3.1 release)
- Critical fixes - critical fixes for severe issue such as silent incorrectness, backwards compatibility, crashes, deadlocks, (large) memory leaks
- Fixes to new features introduced in the most recent release (e.g. 3.3.0 for 3.3.1 release)
- Documentation improvements
- Release branch specific changes (e.g. change version identifiers or CI fixes)
Please note: No feature work allowed for cherry picks. All PRs that are considered for cherry-picks need to be merged on trunk, the only exception are Release branch specific changes. An issue is for tracking cherry-picks to the release branch is created after the branch cut. Only issues that have ‘cherry-picks’ in the issue tracker will be considered for the release.
Cherry-Pick Process
-
Ensure your PR has landed in main. This does not apply for release-branch specific changes.
-
Create (but do not land) a PR against the release branch.
# Find the hash of the commit you want to cherry pick # (for example, abcdef12345) git log git fetch origin release/3.3.x git checkout release/3.3.x git cherry-pick -x abcdef12345 # Submit a PR based against 'release/3.3.x' either: # via the GitHub UI git push my-fork # via the GitHub CLI gh pr create --base release/3.3.x
-
Make a request below with the following format:
Link to landed trunk PR (if applicable):
*
Link to release branch PR:
*
Criteria Category:
*