Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 1 addition & 41 deletions tokio/src/process/unix/pidfd_reaper.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ use crate::{
imp::{orphan::Wait, OrphanQueue},
kill::Kill,
},
util::error::RUNTIME_SHUTTING_DOWN_ERROR,
};

use libc::{syscall, SYS_pidfd_open, ENOSYS, PIDFD_NONBLOCK};
Expand Down Expand Up @@ -95,45 +94,6 @@ where
pidfd: PollEvented<Pidfd>,
}

fn display_eq(d: impl std::fmt::Display, s: &str) -> bool {
use std::fmt::Write;

struct FormatEq<'r> {
remainder: &'r str,
unequal: bool,
}

impl<'r> Write for FormatEq<'r> {
fn write_str(&mut self, s: &str) -> std::fmt::Result {
if !self.unequal {
if let Some(new_remainder) = self.remainder.strip_prefix(s) {
self.remainder = new_remainder;
} else {
self.unequal = true;
}
}
Ok(())
}
}

let mut fmt_eq = FormatEq {
remainder: s,
unequal: false,
};
let _ = write!(fmt_eq, "{d}");
fmt_eq.remainder.is_empty() && !fmt_eq.unequal
}

fn is_rt_shutdown_err(err: &io::Error) -> bool {
if let Some(inner) = err.get_ref() {
err.kind() == io::ErrorKind::Other
&& inner.source().is_none()
&& display_eq(inner, RUNTIME_SHUTTING_DOWN_ERROR)
} else {
false
}
}

impl<W> Future for PidfdReaperInner<W>
where
W: Wait + Unpin,
Expand All @@ -150,7 +110,7 @@ where
}
this.pidfd.registration().clear_readiness(evt);
}
Poll::Ready(Err(err)) if is_rt_shutdown_err(&err) => {}
Poll::Ready(Err(err)) if crate::runtime::is_rt_shutdown_err(&err) => {}
Poll::Ready(Err(err)) => return Poll::Ready(Err(err)),
Poll::Pending => return Poll::Pending,
};
Expand Down
2 changes: 1 addition & 1 deletion tokio/src/runtime/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -569,7 +569,7 @@ cfg_rt! {
pub use handle::{EnterGuard, Handle, TryCurrentError};

mod runtime;
pub use runtime::{Runtime, RuntimeFlavor};
pub use runtime::{Runtime, RuntimeFlavor, is_rt_shutdown_err};

mod id;
pub use id::Id;
Expand Down
69 changes: 69 additions & 0 deletions tokio/src/runtime/runtime.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,11 @@ use crate::runtime::blocking::BlockingPool;
use crate::runtime::scheduler::CurrentThread;
use crate::runtime::{context, EnterGuard, Handle};
use crate::task::JoinHandle;
use crate::util::error::RUNTIME_SHUTTING_DOWN_ERROR;
use crate::util::trace::SpawnMeta;

use std::future::Future;
use std::io;
use std::mem;
use std::time::Duration;

Expand Down Expand Up @@ -513,3 +515,70 @@ impl Drop for Runtime {
impl std::panic::UnwindSafe for Runtime {}

impl std::panic::RefUnwindSafe for Runtime {}

fn display_eq(d: impl std::fmt::Display, s: &str) -> bool {
use std::fmt::Write;

struct FormatEq<'r> {
remainder: &'r str,
unequal: bool,
}

impl<'r> Write for FormatEq<'r> {
fn write_str(&mut self, s: &str) -> std::fmt::Result {
if !self.unequal {
if let Some(new_remainder) = self.remainder.strip_prefix(s) {
self.remainder = new_remainder;
} else {
self.unequal = true;
}
}
Ok(())
}
}

let mut fmt_eq = FormatEq {
remainder: s,
unequal: false,
};
let _ = write!(fmt_eq, "{d}");
fmt_eq.remainder.is_empty() && !fmt_eq.unequal
}

/// Checks whether the given error was emitted by Tokio when shutting down its runtime.
///
/// # Examples
///
/// ```
/// # #[cfg(not(target_family = "wasm"))]
/// # {
/// use tokio::runtime::Runtime;
/// use tokio::net::TcpListener;
///
/// fn main() {
/// let rt1 = Runtime::new().unwrap();
/// let rt2 = Runtime::new().unwrap();
///
/// let listener = rt1.block_on(async {
/// TcpListener::bind("127.0.0.1:0").await.unwrap()
/// });
///
/// drop(rt1);
///
/// rt2.block_on(async {
/// let res = listener.accept().await;
/// assert!(res.is_err());
/// assert!(tokio::runtime::is_rt_shutdown_err(res.as_ref().unwrap_err()));
/// });
/// }
/// # }
/// ```
pub fn is_rt_shutdown_err(err: &io::Error) -> bool {
if let Some(inner) = err.get_ref() {
err.kind() == io::ErrorKind::Other
&& inner.source().is_none()
&& display_eq(inner, RUNTIME_SHUTTING_DOWN_ERROR)
} else {
false
}
}
82 changes: 82 additions & 0 deletions tokio/tests/rt_shutdown_err.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,82 @@
#![warn(rust_2018_idioms)]
#![cfg(feature = "full")]
#![cfg(not(miri))] // No socket in miri.

use std::io;
use tokio::net::TcpListener;
use tokio::runtime::Builder;

fn rt() -> tokio::runtime::Runtime {
Builder::new_current_thread().enable_all().build().unwrap()
}

#[test]
fn test_is_rt_shutdown_err() {
let rt1 = rt();
let rt2 = rt();

let listener = rt1.block_on(async { TcpListener::bind("127.0.0.1:0").await.unwrap() });

drop(rt1);

rt2.block_on(async {
let res = listener.accept().await;
assert!(res.is_err());
let err = res.as_ref().unwrap_err();
assert!(tokio::runtime::is_rt_shutdown_err(err));
});
}

#[test]
fn test_is_not_rt_shutdown_err() {
let err = io::Error::new(io::ErrorKind::Other, "some other error");
assert!(!tokio::runtime::is_rt_shutdown_err(&err));

let err = io::Error::new(io::ErrorKind::NotFound, "not found");
assert!(!tokio::runtime::is_rt_shutdown_err(&err));
}

#[test]
#[cfg_attr(panic = "abort", ignore)]
fn test_join_error_panic() {
let rt = rt();
let handle = rt.spawn(async {
panic!("oops");
});

let join_err = rt.block_on(handle).unwrap_err();
let io_err: io::Error = join_err.into();
assert!(!tokio::runtime::is_rt_shutdown_err(&io_err));
}

#[test]
fn test_join_error_cancelled() {
let rt = rt();
let handle = rt.spawn(async {
std::future::pending::<()>().await;
});
handle.abort();
let join_err = rt.block_on(handle).unwrap_err();
let io_err: io::Error = join_err.into();
assert!(!tokio::runtime::is_rt_shutdown_err(&io_err));
}

#[test]
fn test_other_error_kinds_and_strings() {
// TimedOut
let err = io::Error::new(io::ErrorKind::TimedOut, "timed out");
assert!(!tokio::runtime::is_rt_shutdown_err(&err));

// Interrupted
let err = io::Error::from(io::ErrorKind::Interrupted);
assert!(!tokio::runtime::is_rt_shutdown_err(&err));

// String that contains the shutdown message but has a prefix/suffix
let msg = "A Tokio 1.x context was found, but it is being shutdown. (extra info)";
let err = io::Error::new(io::ErrorKind::Other, msg);
assert!(!tokio::runtime::is_rt_shutdown_err(&err));

let msg = "Error: A Tokio 1.x context was found, but it is being shutdown.";
let err = io::Error::new(io::ErrorKind::Other, msg);
assert!(!tokio::runtime::is_rt_shutdown_err(&err));
}