rt: make is_rt_shutdown_err method public by Keruspe · Pull Request #7771 · tokio-rs/tokio

Keruspe · 2025-12-10T17:20:40Z

This introduces tokio::runtime::is_rt_shutdown_err and uses it in pidfd_reaper where it was previously defined.

This introduces tokio::runtime::is_rt_shutdown_err and uses it in pidfd_reaper where it was previously defined. Fixes tokio-rs#7701

tokio/src/runtime/runtime.rs

Darksonn

Thanks for the PR! It looks reasonable.

tokio/src/runtime/runtime.rs

Co-authored-by: Alice Ryhl <[email protected]>

ADD-SP

Could you add a simple test for this new interface?

Keruspe · 2026-01-04T14:02:14Z

Sorry, I haven't gotten back on this yet, I might be able to update this this week

Darksonn · 2026-01-04T14:18:41Z

No rush. I was just going through the list of open PRs.

Keruspe · 2026-01-07T06:08:59Z

@Darksonn since you added some tests, do you want me to try and iterate on top of that or do you want to finish it up?

Darksonn · 2026-01-07T06:50:10Z

Hrm, it looks like I added tests that don't pass on panic=abort, sorry about that. You can add #[cfg_attr(not(panic="abort"), ignore)] to the relevant tests.

I think this PR is probably fine as-is, unless you have other ideas for additional changes.

disable rustdoc test for wasm (like the other ones around for rt) disable a test when panic=abort is enabled

Keruspe · 2026-01-07T07:19:36Z

Nothing more on my side apart the tests fixing. Should be good now for panic=abort and wasm. Not sure what the problem is for miri if not transient

Darksonn

Thank you

Darksonn · 2026-01-07T08:02:34Z

For the miri error lets add:

#![cfg(not(miri))] // No socket in miri.

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [tokio](https://tokio.rs) ([source](https://github.com/tokio-rs/tokio)) | dependencies | minor | `1.49.0` → `1.50.0` | --- ### Release Notes <details> <summary>tokio-rs/tokio (tokio)</summary> ### [`v1.50.0`](https://github.com/tokio-rs/tokio/releases/tag/tokio-1.50.0): Tokio v1.50.0 [Compare Source](tokio-rs/tokio@tokio-1.49.0...tokio-1.50.0) ### 1.50.0 (Mar 3rd, 2026) ##### Added - net: add `TcpStream::set_zero_linger` ([#7837]) - rt: add `is_rt_shutdown_err` ([#7771]) ##### Changed - io: add optimizer hint that `memchr` returns in-bounds pointer ([#7792]) - io: implement vectored writes for `write_buf` ([#7871]) - runtime: panic when `event_interval` is set to 0 ([#7838]) - runtime: shorten default thread name to fit in Linux limit ([#7880]) - signal: remember the result of `SetConsoleCtrlHandler` ([#7833]) - signal: specialize windows `Registry` ([#7885]) ##### Fixed - io: always cleanup `AsyncFd` registration list on deregister ([#7773]) - macros: remove (most) local `use` declarations in `tokio::select!` ([#7929]) - net: fix `GET_BUF_SIZE` constant for `target_os = "android"` ([#7889]) - runtime: avoid redundant unpark in current\_thread scheduler ([#7834]) - runtime: don't park in `current_thread` if `before_park` defers waker ([#7835]) - io: fix write readiness on ESP32 on short writes ([#7872]) - runtime: wake deferred tasks before entering `block_in_place` ([#7879]) - sync: drop rx waker when oneshot receiver is dropped ([#7886]) - runtime: fix double increment of `num_idle_threads` on shutdown ([#7910], [#7918], [#7922]) ##### Unstable - fs: check for io-uring opcode support ([#7815]) - runtime: avoid lock acquisition after uring init ([#7850]) ##### Documented - docs: update outdated unstable features section ([#7839]) - io: clarify the behavior of `AsyncWriteExt::shutdown()` ([#7908]) - io: explain how to flush stdout/stderr ([#7904]) - io: fix incorrect and confusing `AsyncWrite` documentation ([#7875]) - rt: clarify the documentation of `Runtime::spawn` ([#7803]) - rt: fix missing quotation in docs ([#7925]) - runtime: correct the default thread name in docs ([#7896]) - runtime: fix `event_interval` doc ([#7932]) - sync: clarify RwLock fairness documentation ([#7919]) - sync: clarify that `recv` returns `None` once closed and no more messages ([#7920]) - task: clarify when to use `spawn_blocking` vs dedicated threads ([#7923]) - task: doc that task drops before `JoinHandle` completion ([#7825]) - signal: guarantee that listeners never return `None` ([#7869]) - task: fix task module feature flags in docs ([#7891]) - task: fix two typos ([#7913]) - task: improve the docs of `Builder::spawn_local` ([#7828]) - time: add docs about auto-advance and when to use sleep ([#7858]) - util: fix typo in docs ([#7926]) [#7771]: tokio-rs/tokio#7771 [#7773]: tokio-rs/tokio#7773 [#7792]: tokio-rs/tokio#7792 [#7803]: tokio-rs/tokio#7803 [#7815]: tokio-rs/tokio#7815 [#7825]: tokio-rs/tokio#7825 [#7828]: tokio-rs/tokio#7828 [#7833]: tokio-rs/tokio#7833 [#7834]: tokio-rs/tokio#7834 [#7835]: tokio-rs/tokio#7835 [#7837]: tokio-rs/tokio#7837 [#7838]: tokio-rs/tokio#7838 [#7839]: tokio-rs/tokio#7839 [#7850]: tokio-rs/tokio#7850 [#7858]: tokio-rs/tokio#7858 [#7869]: tokio-rs/tokio#7869 [#7871]: tokio-rs/tokio#7871 [#7872]: tokio-rs/tokio#7872 [#7875]: tokio-rs/tokio#7875 [#7879]: tokio-rs/tokio#7879 [#7880]: tokio-rs/tokio#7880 [#7885]: tokio-rs/tokio#7885 [#7886]: tokio-rs/tokio#7886 [#7889]: tokio-rs/tokio#7889 [#7891]: tokio-rs/tokio#7891 [#7896]: tokio-rs/tokio#7896 [#7904]: tokio-rs/tokio#7904 [#7908]: tokio-rs/tokio#7908 [#7910]: tokio-rs/tokio#7910 [#7913]: tokio-rs/tokio#7913 [#7918]: tokio-rs/tokio#7918 [#7919]: tokio-rs/tokio#7919 [#7920]: tokio-rs/tokio#7920 [#7922]: tokio-rs/tokio#7922 [#7923]: tokio-rs/tokio#7923 [#7925]: tokio-rs/tokio#7925 [#7926]: tokio-rs/tokio#7926 [#7929]: tokio-rs/tokio#7929 [#7932]: tokio-rs/tokio#7932 </details> --- ### Configuration 📅 **Schedule**: Branch creation - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) in timezone Pacific/Auckland, Automerge - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) in timezone Pacific/Auckland. 🚦 **Automerge**: Disabled because a matching PR was automerged previously. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://harton.dev/project-neon/neonfs/pulls/53 Co-authored-by: Renovate Bot <[email protected]> Co-committed-by: Renovate Bot <[email protected]>

Keruspe marked this pull request as draft December 11, 2025 07:54

Keruspe force-pushed the rt-shutdown-error branch from 5f26c8f to 640c000 Compare December 11, 2025 07:55

rt: make is_rt_shutdown_err method public

0ca69e7

This introduces tokio::runtime::is_rt_shutdown_err and uses it in pidfd_reaper where it was previously defined. Fixes tokio-rs#7701

Keruspe force-pushed the rt-shutdown-error branch from 640c000 to 0ca69e7 Compare December 11, 2025 07:57

Keruspe marked this pull request as ready for review December 11, 2025 08:06

ADD-SP added A-tokio Area: The main tokio crate M-runtime Module: tokio/runtime labels Dec 11, 2025

martin-g reviewed Dec 16, 2025

View reviewed changes

tokio/src/runtime/runtime.rs Show resolved Hide resolved

martin-g approved these changes Dec 16, 2025

View reviewed changes

Darksonn reviewed Dec 16, 2025

View reviewed changes

tokio/src/runtime/runtime.rs Outdated Show resolved Hide resolved

Update tokio/src/runtime/runtime.rs

1d32eab

Co-authored-by: Alice Ryhl <[email protected]>

ADD-SP reviewed Dec 25, 2025

View reviewed changes

ADD-SP added the S-waiting-on-author Status: awaiting some action (such as code changes) from the PR or issue author. label Dec 31, 2025

docs: improve is_rt_shutdown_err example and add tests

bd91e39

rt: try to make the CI pass

afeee34

disable rustdoc test for wasm (like the other ones around for rt) disable a test when panic=abort is enabled

Keruspe force-pushed the rt-shutdown-error branch from 2ca0982 to afeee34 Compare January 7, 2026 07:18

rt: actually fix panic=abort tests

e28e8ef

Darksonn approved these changes Jan 7, 2026

View reviewed changes

Darksonn enabled auto-merge (squash) January 7, 2026 07:36

Merge branch 'master' into rt-shutdown-error

c5c180d

rt: disable rt_shutdown_err test on miri

8475eb6

auto-merge was automatically disabled January 7, 2026 08:07
Head branch was pushed to by a user without write access

Darksonn enabled auto-merge (squash) January 7, 2026 08:08

Darksonn merged commit d65165f into tokio-rs:master Jan 7, 2026
88 checks passed

winter-loo pushed a commit to winter-loo/tokio that referenced this pull request Jan 9, 2026

rt: make is_rt_shutdown_err method public (tokio-rs#7771)

9bbd70c

ADD-SP mentioned this pull request Feb 25, 2026

chore: prepare Tokio v1.50.0 #7934

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

rt: make is_rt_shutdown_err method public#7771

rt: make is_rt_shutdown_err method public#7771
Darksonn merged 7 commits intotokio-rs:masterfrom
Keruspe:rt-shutdown-error

Keruspe commented Dec 10, 2025

Uh oh!

Uh oh!

Darksonn left a comment

Uh oh!

Uh oh!

ADD-SP left a comment

Uh oh!

Keruspe commented Jan 4, 2026

Uh oh!

Darksonn commented Jan 4, 2026

Uh oh!

Keruspe commented Jan 7, 2026

Uh oh!

Darksonn commented Jan 7, 2026

Uh oh!

Keruspe commented Jan 7, 2026

Uh oh!

Darksonn left a comment

Uh oh!

Darksonn commented Jan 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

Keruspe commented Dec 10, 2025

Uh oh!

Uh oh!

Darksonn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ADD-SP left a comment

Choose a reason for hiding this comment

Uh oh!

Keruspe commented Jan 4, 2026

Uh oh!

Darksonn commented Jan 4, 2026

Uh oh!

Keruspe commented Jan 7, 2026

Uh oh!

Darksonn commented Jan 7, 2026

Uh oh!

Keruspe commented Jan 7, 2026

Uh oh!

Darksonn left a comment

Choose a reason for hiding this comment

Uh oh!

Darksonn commented Jan 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants