fix: support current_timestamp #5061
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sqlglot/dialects/druid.py
Outdated
Comment on lines
15
to
18
|
|
||
| def currenttimestamp_sql(self, expression: exp.CurrentTimestamp) -> str: | ||
| this = expression.this | ||
| return self.func("CURRENT_TIMESTAMP", this) if this else "CURRENT_TIMESTAMP" |
Collaborator
There was a problem hiding this comment.
We don't want a function right? You can only use it without parentheses.
Contributor
Author
There was a problem hiding this comment.
Interesting, it worked for my usecase but i see the way you've done it in your commit. Thanks !
georgesittas
changed the title
georgesittas
changed the title
georgesittas
added a commit
that referenced
this pull request
May 10, 2025
* feat: added support for current_timestamp * test: Added tests for current_timestamp --------- Co-authored-by: Jo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5059