Skip to content

fix: support current_timestamp #5061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
georgesittas merged 3 commits into from
May 10, 2025
+3 −1
Merged

fix: support current_timestamp #5061

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3ea8180
feat: added support for current_timestamp
ALongJohnson May 10, 2025
1eef19e
test: Added tests for current_timestamp
ALongJohnson May 10, 2025
907ddaa
Merge branch 'main' into druid-current-timestamp
georgesittas May 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions sqlglot/dialects/druid.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,7 @@ class Generator(generator.Generator):
exp.DataType.Type.TEXT: "STRING",
exp.DataType.Type.UUID: "STRING",
}

def currenttimestamp_sql(self, expression: exp.CurrentTimestamp) -> str:
this = expression.this
return self.func("CURRENT_TIMESTAMP", this) if this else "CURRENT_TIMESTAMP"
Copy link
Collaborator

@georgesittas georgesittas May 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want a function right? You can only use it without parentheses.

Copy link
Contributor Author

@ALongJohnson ALongJohnson May 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, it worked for my usecase but i see the way you've done it in your commit. Thanks !

3 changes: 2 additions & 1 deletion tests/dialects/test_druid.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@ def test_druid(self):
self.validate_identity("SELECT FLOOR(__time TO WEEK) FROM t")
self.validate_identity("SELECT FLOOR(col) FROM t")
self.validate_identity("SELECT FLOOR(price, 2) AS rounded_price FROM t")

self.validate_identity("SELECT CURRENT_TIMESTAMP")

# validate across all dialects
write = {dialect.value: "FLOOR(__time TO WEEK)" for dialect in Dialects}
self.validate_all(
Expand Down
Loading