This repository was archived by the owner on May 22, 2022. It is now read-only.
properly handle test dependencies#40
Open
jtjeferreira wants to merge 1 commit intotkawachi:masterfrom
Open
Conversation
Contributor
Author
|
hi @tkawachi could you have a look at the PR? do you think I need to improve anything? |
Contributor
Author
|
hi @tkawachi any chance to have a look at this? |
|
Can we merge this? The plugin is basically completely broken without it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses
dependencyOverridesinstead ofCompile / dependencyOverridesbecause otherwise it is unused. However to also fix the use case presented in #30, this PR also looks intoTestclasspath and adds these modules to thedependencyOverrideswith thetestconfiguration...I tested this in my work project and the changes were minimal
fixes #34
An improvement to this could be adding a new setting to control, how test dependencies should be added: