This repository was archived by the owner on May 22, 2022. It is now read-only.
Config scope: dependencyOverrides in Compile (not Test)#30
Merged
tkawachi merged 1 commit intotkawachi:masterfrom Oct 7, 2019
Merged
Config scope: dependencyOverrides in Compile (not Test)#30tkawachi merged 1 commit intotkawachi:masterfrom
tkawachi merged 1 commit intotkawachi:masterfrom
Conversation
Contributor
Author
|
cc: @rallydan |
Contributor
Author
|
Build is unhappy. |
Owner
|
Thank you for PR. Cloud you rebase on master branch? |
Contributor
Author
|
Done. Thanks, @tkawachi! Also, this relates to #28. fyi, @stephanos. |
Contributor
|
after this change, I get in sbt 1.4.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Currently we have:
src/main/scala -> jackson-databind 2.7.x
src/test/scala -> jackson-databind 2.9.x
sbt lock chooses the 2.7.x version and sets for all configurations (including
Test). Our tests which depend on 2.9.x fail since they require a method that does not exist.Solution
This PR restricts the
dependencyOverridesto only theCompilescope, since that seems to be where they're describing.