refactor: rename Wallet field, add alias#4
Closed
thunderbiscuit wants to merge 2 commits intomasterfrom
Closed
Conversation
thunderbiscuit
force-pushed
the
refactor/tx_graph
branch
from
a831a1e to
f0190ee
Compare
110CodingP
force-pushed
the
refactor/tx_graph
branch
from
f0190ee to
c199d64
Compare
Collaborator
|
ACK c199d64 |
110CodingP
changed the title
Wallet fields, add alias
110CodingP
changed the title
Wallet fields, add aliasWallet field, add alias
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renamed
Wallet::indexed_graphtoWallet::tx_graphas the latter is a better name representing the field. Also introduced a type aliasKeychainTxGraphfor convenience.Note: This PR helps with the multi-keychain work being done in bdk_wallet#318 and bdk_wallet#367.
Changelog:
Added
KeychainTxGraph<K>forIndexedTxGraph<ConfirmationBlockTime, KeychainTxOutIndex<K>>.Changed
Wallet::indexed_graphtoWallet::tx_graph.