[Test PR] Multi-Keychain Wallets#367
Closed
thunderbiscuit wants to merge 6 commits intobitcoindevkit:masterfrom
Closed
[Test PR] Multi-Keychain Wallets#367thunderbiscuit wants to merge 6 commits intobitcoindevkit:masterfrom
thunderbiscuit wants to merge 6 commits intobitcoindevkit:masterfrom
Conversation
thunderbiscuit
force-pushed
the
feature/multi-keychain-wallet-2
branch
from
4e97057 to
52369dc
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #367 +/- ##
===========================================
- Coverage 85.33% 61.89% -23.45%
===========================================
Files 24 25 +1
Lines 8335 4461 -3874
===========================================
- Hits 7113 2761 -4352
- Misses 1222 1700 +478
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
thunderbiscuit
force-pushed
the
feature/multi-keychain-wallet-2
branch
from
52369dc to
7f6c2be
Compare
thunderbiscuit
force-pushed
the
feature/multi-keychain-wallet-2
branch
from
7f6c2be to
c9610e7
Compare
This was referenced Jan 27, 2026
Member
Author
|
This was a good test, and we decided to go with this approach in #318. Closing now. |
ValuedMammal
added a commit
that referenced
this pull request
Feb 10, 2026
4b77231 refactor: rename Wallet indexed_graph field to tx_graph (codingp110) Pull request description: ### Description Renamed `Wallet::indexed_graph` to `Wallet::tx_graph` as the latter is a better name representing the field. ### Notes to the reviewers This PR helps with the multi-keychain work being done in #318 and #367 . ### Changelog notice ### Changed - Renamed `Wallet::indexed_graph` to `Wallet::tx_graph`. ### Checklists #### All Submissions: * [x] I've signed all my commits * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md) * [x] I ran `just p` before pushing ACKs for top commit: ValuedMammal: ACK 4b77231 Tree-SHA512: bef7e576765efa965e952fe0335f4bd1cc31bfbc2ce9bd27ae1a4084a8515d2b6b5b00cdf439f766e2b932f9d0f9ffde8e148dfb960ae014c2d4b5d17658a55a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is more of a test PR to try and see if I can make simpler #318 by approaching it completely differently, i.e. not with a lot of small commits that are really hard to rebase but rather a few, much bigger commits that concern specific areas of the codebase.
Changelog notice
Checklists
All Submissions:
just pbefore pushingNew Features:
Bugfixes: