fix(t8s-cluster): only allow nodePools with valid k8s names

[cwrau]

Summary by CodeRabbit

• Bug Fixes
  • Enforced node pool name validation (allowed characters and max length 32) to prevent invalid names.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[gemini-code-assist]

Summary of Changes

Hello @cwrau, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the t8s-cluster Helm chart by implementing stricter validation for node pool names within its values.schema.json. By enforcing Kubernetes naming conventions, it ensures that all node pool names adhere to required standards, which helps prevent potential deployment issues related to invalid resource naming and improves the overall robustness of cluster configurations.

Highlights

• Schema Validation for Node Pool Names: Introduced a regular expression pattern to enforce valid Kubernetes naming conventions for node pool names within the t8s-cluster Helm chart's values.schema.json.
• Updated Schema Property Handling: Replaced the generic additionalProperties with patternProperties in the nodePools definition to apply the new naming validation rule to node pool keys.
• Strict Property Enforcement: Added additionalProperties: false to the nodePools object to ensure that only explicitly defined or pattern-matching properties are allowed, preventing unexpected configurations.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[coderabbitai]

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Walkthrough

Added a top-level propertyNames constraint to nodePools in the Helm chart values schema, enforcing a regex and a maximum length for node pool names; no other per-pool schema fields were changed.

Changes

Cohort / File(s)	Summary
Helm Chart Schema — nodePools name constraint charts/t8s-cluster/values.schema.json	Added nodePools.propertyNames with regex ^[a-z0-9]([-a-z0-9]*[a-z0-9])?$ and maxLength: 32 to validate pool names. No changes to individual pool schemas or required fields.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

• Areas to spot-check:
  • Confirm the regex exactly matches intended allowed pool name formats.
  • Verify maxLength: 32 aligns with any downstream name length limits or providers.
  • Test schema validation against representative existing nodePools names to ensure backward compatibility.

Suggested reviewers

• tasches
• marvinWolff

Poem

🐰 In the meadow of charts I hop and sing,
Names trimmed tidy, thirty-two's the ring,
A regex snug, no stray hyphen roam,
Node pools prance in their cozy home. 🥕

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: adding validation to enforce that nodePools use valid Kubernetes-compliant names.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/t8s-cluster/validate-nodepool-names

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 83b0e83 and 1130760.

📒 Files selected for processing (1)

• charts/t8s-cluster/values.schema.json (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• charts/t8s-cluster/values.schema.json

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: lint helm chart (t8s-cluster)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[gemini-code-assist]

Code Review

This pull request improves the validation for nodePools by ensuring their names are valid Kubernetes-style names (DNS-1123 labels). This is a good change to prevent invalid configurations. I've suggested a small improvement to also validate the maximum length of the node pool name, making the validation more complete.

[Copilot]

Pull request overview

This PR adds validation to ensure nodePool names follow Kubernetes DNS label naming conventions. The change prevents users from creating nodePools with invalid names that would cause issues when resources are created in Kubernetes.

• Replaces additionalProperties with patternProperties using a regex pattern that validates Kubernetes DNS-1123 label names
• Adds additionalProperties: false to explicitly reject nodePool names that don't match the pattern

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.