Upgrade asserts with teyit for Python 3.11 compatibility #319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
What does "teyit" mean? |
Contributor
Author
|
It's this handy tool: https://github.com/isidentical/teyit |
stephenfin
approved these changes
Feb 7, 2022
Contributor
|
Can you rebase this? The branch doesn't have the |
Contributor
Author
|
Hmm, strange the flag looks enabled for me:
Anyway, rebased! |
cjwatson
approved these changes
Apr 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use https://github.com/isidentical/teyit to upgrade unittest asserts for better error messages.
Also
assertEqualshas been removed in 3.11, so useassertEqualinstead.https://docs.python.org/3.11/whatsnew/3.11.html
There are still some other things needed for 3.11 compatibility but this is a first step.