(#145) Added intake open voltage down when intaking#147
Merged
Conversation
aidnem
approved these changes
Mar 21, 2026
Contributor
aidnem
left a comment
aidnem
left a comment
There was a problem hiding this comment.
I'm approving this so we can move forward but there is some stuff that needs changes. Can we please see a 2nd ticket that can clean up the technical debt here?
| if (Radians.of(world.pivotInputs.positionRadians) | ||
| .isNear( | ||
| world.targetPivotAngle, JsonConstants.intakeConstants.pivotHoldAngleTolerance) | ||
| && world.holdVoltage != null) { |
Contributor
There was a problem hiding this comment.
@avidraccoon since this is your solution, can you make a ticket to use an optional for this instead
| } | ||
|
|
||
| // Holds the intake down with a set voltage when intaking | ||
| if (runningIntakeRollers && deployIntake) { |
Contributor
There was a problem hiding this comment.
This is unnecessary right now. We don't need it. @avidraccoon please add it to your new ticket as well.
aidnem
approved these changes
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.