Conversation
charlesmackenzie
force-pushed
the
arm-rework
branch
from
9d608c6 to
1c2dd4c
Compare
jkleiber
left a comment
jkleiber
left a comment
There was a problem hiding this comment.
Half of a first pass. I'm a bit confused how all of the arm stuff works together in this PR since arm subsystem looks deleted
There was a problem hiding this comment.
To avoid merge conflicts, I would just delete this file since @redPlover is deleting it
There was a problem hiding this comment.
probably should delete this file since @redPlover is deleting it in his branch
There was a problem hiding this comment.
Probably best to delete this one too since it's being deleted in #35
There was a problem hiding this comment.
this file is being deleted in #35 and isn't related to the arm - best move is to revert all changes or delete it to avoid merge conflicts
| private final WristSubsystem wrist = new WristSubsystem(); | ||
| private final IntakeSubsystem intake = new IntakeSubsystem(); | ||
| // private final Drive drive = new Drive(); | ||
| private final ArmSubsystem arm; |
There was a problem hiding this comment.
It looks like ArmSubsystem has been deleted, so it isn't clear how this will work
charlesmackenzie
force-pushed
the
arm-rework
branch
from
6e403ef to
860de98
Compare
3 participants
I'm attempting to address the first part of #31 by aggressively refactoring the arm code. Changes focus on understandably and straightforwardness.
Need to do:
Add some unit tests?Thismightwill become another PRNotes:
AdvantageKit implementation will take place in another PR.YOLO