Add test for Number.MAX_VALUE's value#5026
Merged
Conversation
ljharb
approved these changes
Apr 15, 2026
Sharktheone
force-pushed
the
number-max-value
branch
from
1e7c312 to
63984c6
Compare
ptomato
reviewed
Apr 21, 2026
| assert(Number.MAX_VALUE < Infinity, "Number.MAX_VALUE should be less than Infinity"); | ||
|
|
||
| assert.sameValue(Number.MAX_VALUE * 2, Infinity, "Number.MAX_VALUE multiplied by 2 should be Infinity"); | ||
| assert.sameValue(Number.MAX_VALUE, 1.7976931348623157e+308, "Number.MAX_VALUE should be approximately 1.7976931348623157e+308"); |
Contributor
There was a problem hiding this comment.
I don't get why the spec says "approximately" here but I guess it's OK to use the same language 😄
Member
Author
There was a problem hiding this comment.
I'm not sure. I don't think any valid impl can use anything different than float64 for it's number type. But I agree, I wasn't sure at first.
ptomato
force-pushed
the
number-max-value
branch
from
63984c6 to
b263a80
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as for #5025, there where no tests in place for
Number.MAX_VALUE's value, so I am adding this here.I'm directly checking the value against the value mentioned in the spec (
1.7976931348623157e+308) as there are no denormalized values we need to take into account here.The test again passes in Yavashark and I would strongly assume that it will pass in all other engines too.