Add test for Number.MIN_VALUE's value#5025
Merged
Conversation
ljharb
approved these changes
Apr 15, 2026
Sharktheone
force-pushed
the
number-min-value
branch
from
604f689 to
d4d9590
Compare
Member
Author
ptomato
approved these changes
Apr 21, 2026
ptomato
force-pushed
the
number-min-value
branch
from
d4d9590 to
40bcf8b
Compare
Contributor
|
For #5027, someone will need to find time to review it, as it isn't simple enough to be done in a short time like the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There where no tests in place to actually test what
Number.MIN_VALUEis. The testsuite would happily accept any value, negative or high positive ones.I dividing the
Number.MIN_VALUEby 2 and check if it is 0 as the spec mentions denormalized values which we need to account for here.I checked that the test passes in Yavashark (my own JS Engine) and from looking at all other Engines they should pass this new test too.