Editorial: Stylize strings as values.#396
Merged
leobalter merged 2 commits intotc39:masterfrom Dec 20, 2019
Merged
Conversation
rkirsling
approved these changes
Dec 19, 2019
Member
rkirsling
left a comment
There was a problem hiding this comment.
Woot! I'm so jealous that 402 is a multi-file spec. 😄
|
|
||
| <p> | ||
| EXAMPLES `"ß"` (U+00DF) must not match or be mapped to `"SS"` (U+0053, U+0053). `"ı"` (U+0131) must not match or be mapped to `"I"` (U+0049). | ||
| EXAMPLES *"ß"* (U+00DF) must not match or be mapped to *"SS"* (U+0053, U+0053). *"ı"* (U+0131) must not match or be mapped to *"I"* (U+0049). |
Member
There was a problem hiding this comment.
The only concern I see is that we may wish to change cases like *"ß"* (U+00DF) to `ß` (U+00DF) throughout this file, in alignment with, say, Note 4 of 21.2.2.8.2 in 262.
I don't have a strong opinion on this though, particularly since we're referring to these as "characters". (@jmdyck, what do you think?)
There was a problem hiding this comment.
It seems to me that it's incorrect for the preceding para to talk about ES String values as if they consist of Unicode code points.
Member
There was a problem hiding this comment.
I believe this can be done through a separate patch if necessary.
leobalter
approved these changes
Dec 20, 2019
This was referenced Jan 31, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows the convention set in ECMA-262 to format strings as literals (
*"string*"instead of`"string"`, see PR: tc39/ecma262#1733) and closes #54.There is also one commit that adds a link in 5. Notational Conventions to ECMA-262.
While reviewing, consider the following conventions from ECMA-262 that I'm not positive apply here:
~.