Skip to content

Normative: Adding Intl.RelativeTimeFormat specification#391

Merged
leobalter merged 3 commits intotc39:masterfrom
caiolima:intl-relative-time-format
Feb 26, 2020
Merged

Normative: Adding Intl.RelativeTimeFormat specification#391
leobalter merged 3 commits intotc39:masterfrom
caiolima:intl-relative-time-format

Conversation

@caiolima
Copy link
Copy Markdown
Contributor

@caiolima caiolima commented Nov 25, 2019

Adding specification text from https://github.com/tc39/proposal-intl-relative-time to the main spec.

@longlho
Copy link
Copy Markdown
Collaborator

longlho commented Nov 27, 2019

Can this wait for the remaining PRs in https://github.com/tc39/proposal-intl-relative-time to be resolved?

@ljharb ljharb added the stage 3 label Nov 27, 2019
@caiolima
Copy link
Copy Markdown
Contributor Author

caiolima commented Nov 27, 2019

Can this wait for the remaining PRs in https://github.com/tc39/proposal-intl-relative-time to be resolved?

This PR is blocked until we merge all PRs on proposal's repo. Also, it needs to wait until we get stage 4 status from TC39.

@longlho
Copy link
Copy Markdown
Collaborator

longlho commented Nov 27, 2019

thanks for the explanation!

@leobalter
Copy link
Copy Markdown
Member

leobalter commented Jan 9, 2020

@caiolima any updates since then?

@littledan littledan mentioned this pull request Jan 9, 2020
Closed
@littledan
Copy link
Copy Markdown
Member

littledan commented Jan 9, 2020

Now that Intl.RelativeTimeFormat is at Stage 4, I think this PR is good to land (modulo editor reviews).

@caiolima caiolima force-pushed the intl-relative-time-format branch from 22afab7 to 8565d80 Compare January 15, 2020 20:49
@caiolima
Copy link
Copy Markdown
Contributor Author

caiolima commented Jan 15, 2020

@caiolima any updates since then?

@leobalter just rebased it.

@leobalter leobalter removed the stage 3 label Jan 24, 2020
@leobalter leobalter requested a review from spectranaut January 24, 2020 20:10
@leobalter leobalter added the has consensus Has consensus from TC39-TG2 label Jan 24, 2020
spectranaut
spectranaut requested changes Jan 31, 2020
View reviewed changes
Copy link
Copy Markdown

@spectranaut spectranaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few minor editorial requests before we merge this PR. Most of the work is changing the string literal format, I linked the PRs you can use as an example of what should change!

Comment thread spec/relativetimeformat.html Outdated
Comment thread spec/relativetimeformat.html Outdated
Comment thread spec/relativetimeformat.html Outdated
Comment thread spec/relativetimeformat.html Outdated
Comment thread spec/relativetimeformat.html Outdated
Comment thread spec/relativetimeformat.html Outdated
caiolima
caiolima commented Feb 3, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@caiolima caiolima left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the review

Comment thread spec/relativetimeformat.html Outdated
Comment thread spec/relativetimeformat.html Outdated
Comment thread spec/relativetimeformat.html Outdated
spectranaut
spectranaut approved these changes Feb 3, 2020
View reviewed changes
Copy link
Copy Markdown

@spectranaut spectranaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@leobalter leobalter merged commit c5417aa into tc39:master Feb 26, 2020
sideshowbarker added a commit to w3c/browser-compat-data that referenced this pull request Mar 4, 2020
@sideshowbarker
RelativeTimeFormat now in ECMA402; update spec URLs
394e420 
tc39/ecma402#391 moved the RelativeTimeFormat
into the ECMA402 specification. This change updates the associated BCD
spec URLs.

tc39/ecma402@c5417aa
sideshowbarker added a commit to w3c/browser-compat-data that referenced this pull request Mar 4, 2020
@sideshowbarker
RelativeTimeFormat now in ECMA402; update spec URLs
8680701 
tc39/ecma402#391 moved RelativeTimeFormat into
the ECMA402 spec. This change updates the associated BCD spec URLs.

tc39/ecma402@c5417aa
@sideshowbarker sideshowbarker mentioned this pull request Mar 4, 2020
Merged
Elchi3 pushed a commit to mdn/browser-compat-data that referenced this pull request Mar 4, 2020
@sideshowbarker
RelativeTimeFormat now in ECMA402; update spec URLs (#5777)
208955a 
tc39/ecma402#391 moved RelativeTimeFormat into
the ECMA402 spec. This change updates the associated BCD spec URLs.

tc39/ecma402@c5417aa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leobalter leobalter leobalter approved these changes

@spectranaut spectranaut spectranaut approved these changes

Assignees

@spectranaut spectranaut

Labels

has consensus Has consensus from TC39-TG2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@caiolima @longlho @leobalter @littledan @spectranaut @ljharb