[Spec] MSC2285 Stable/Unstable crossover period support#717
Merged
EdGeraghty merged 13 commits intodevfrom Sep 11, 2022
Merged
Conversation
added 5 commits
August 19, 2022 21:23
added 6 commits
August 19, 2022 22:23
Added a Deprecation notice, track against Synapse
ereio
reviewed
Sep 11, 2022
| case ReadReceiptTypes.Private: | ||
| return Strings.labelPrivate; | ||
|
|
||
| default: //I've not been coded for this one yet |
Member
There was a problem hiding this comment.
What is the functionality expected behind this one?
Collaborator
Author
There was a problem hiding this comment.
Purely defensive. The only two in the spec (on and private) + Off are handled above it. Feel free to patch out as wanted, it's on origin
Collaborator
Author
There was a problem hiding this comment.
Note this is purely to handle string translation
ereio
reviewed
Sep 11, 2022
Member
ereio
left a comment
ereio
left a comment
There was a problem hiding this comment.
Other than the question I posted, this looks good. Great work!
Once that's clear, will approve. Can we set the switch block default to return Strings.labelOn? I'm assuming the actual default setting will still be "Off" correct?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types
Changes
🔮 Features
🐛 Fixes
🔒 Security
🛠 Performance
📐 Refactoring
Media (if applicable)
QA
Final Checklist