-
Notifications
You must be signed in to change notification settings - Fork 174
✨(frontend) add Ctrl+Shift+/ to open shortcuts settings #1050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
7ebc928
487340e
f1ddd7f
8362ac0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -172,3 +172,16 @@ | |
| display: flex; | ||
| align-items: center; | ||
| } | ||
|
|
||
| /* Shortcut hint: visible only on first grid tile when focused (CSS-based) */ | ||
| .shortcut-hint-wrapper { | ||
| opacity: 0; | ||
| visibility: hidden; | ||
| pointer-events: none; | ||
| transition: opacity 150ms ease; | ||
| } | ||
|
Comment on lines
+176
to
+182
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. D’après ce que j’ai pu constater, le hint n’apparaît que lorsque tu cliques réellement sur la participant tile, ou sur le menu de métadonnées qui s’affiche au survol. Autrement dit, le raccourci n’apparaît pas en même temps que le menu d’actions de la participant tile (qui, lui, s’affiche au survol), mais uniquement lorsqu’il y a un véritable focus sur la participant tile. En y réfléchissant, je me demande si cette fonctionnalité n’est pas surtout pertinente pour les utilisateurs de lecteurs d’écran. Peut-être qu’un jour, on préférera réserver le coin droit à autre chose : on pourra en reparler le moment venu. En tout cas, ce comportement est différent de ce que j’imaginais : les actions supplémentaires d’une participant tile apparaissent au survol, tandis que le raccourci, lui, n’apparaît qu’au moment où la partie mentale reçoit effectivement le focus. On peut ship comme ça, c'est un peu nit picking. |
||
| .lk-grid-layout > *:first-child:focus-within .shortcut-hint-wrapper { | ||
| opacity: 1; | ||
| visibility: visible; | ||
| pointer-events: auto; | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick : I think the KBD styling should apply only to the actual key being pressed, not to the plus sign. Showing the "+" inside the KBD component could be misleading, as it might suggest that users need to press the "+" key specifically, rather than indicating a key combination.