✨(frontend) add Ctrl+Shift+/ to open shortcuts settings#1050
Conversation
Ovgodd
changed the title
Ovgodd
force-pushed
the
feat/shortcut-hint-css-first-tile
branch
from
0fa84a1 to
d3b3377
Compare
Ovgodd
force-pushed
the
feat/shortcut-hint-css-first-tile
branch
3 times, most recently
from
50ec16d to
9975a5f
Compare
src/frontend/src/features/rooms/livekit/prefabs/VideoConference.tsx
Outdated
Show resolved
Hide resolved
Ovgodd
force-pushed
the
feat/shortcut-hint-css-first-tile
branch
2 times, most recently
from
a364f8b to
6027026
Compare
lebaudantoine
left a comment
lebaudantoine
left a comment
There was a problem hiding this comment.
Let's address my comment in dedicated issue when needed.
| <kbd className={cx(badgeStyle, className)} aria-hidden="true"> | ||
| {visualLabel} | ||
| </kbd> |
There was a problem hiding this comment.
nitpick : I think the KBD styling should apply only to the actual key being pressed, not to the plus sign. Showing the "+" inside the KBD component could be misleading, as it might suggest that users need to press the "+" key specifically, rather than indicating a key combination.
| /* Shortcut hint: visible only on first grid tile when focused (CSS-based) */ | ||
| .shortcut-hint-wrapper { | ||
| opacity: 0; | ||
| visibility: hidden; | ||
| pointer-events: none; | ||
| transition: opacity 150ms ease; | ||
| } |
There was a problem hiding this comment.
D’après ce que j’ai pu constater, le hint n’apparaît que lorsque tu cliques réellement sur la participant tile, ou sur le menu de métadonnées qui s’affiche au survol.
Autrement dit, le raccourci n’apparaît pas en même temps que le menu d’actions de la participant tile (qui, lui, s’affiche au survol), mais uniquement lorsqu’il y a un véritable focus sur la participant tile.
En y réfléchissant, je me demande si cette fonctionnalité n’est pas surtout pertinente pour les utilisateurs de lecteurs d’écran. Peut-être qu’un jour, on préférera réserver le coin droit à autre chose : on pourra en reparler le moment venu.
En tout cas, ce comportement est différent de ce que j’imaginais : les actions supplémentaires d’une participant tile apparaissent au survol, tandis que le raccourci, lui, n’apparaît qu’au moment où la partie mentale reçoit effectivement le focus.
On peut ship comme ça, c'est un peu nit picking.
Update toolbar hint and register shortcut to open settings on shortcuts tab
Register Ctrl+Shift+F in DesktopControlBar, Ctrl+Shift+L in ToolsToggle
Use :first-child and :focus-within to restrict hint visibility to the first tile
Ovgodd
force-pushed
the
feat/shortcut-hint-css-first-tile
branch
from
6027026 to
1f83311
Compare
caption, th scope, <kbd> for keys, no Tab stops on rows
Ovgodd
force-pushed
the
feat/shortcut-hint-css-first-tile
branch
from
1f83311 to
8362ac0
Compare
|
2 participants
Purpose
Display the keyboard shortcut hint (Ctrl+Shift+/), Only in the first participant tile in the grid to avoid repetition and visual clutter.
last part from this #859 PR slicing
issue : #855
Proposal
:first-child+:focus-within)