[Mellanox]support led for fan/psu and fan direction by stephenxs · Pull Request #17 · stephenxs/sonic-buildimage

stephenxs · 2019-11-20T03:08:21Z

- What I did
support led for fan/psu and fan direction
It depends on add fan direction "not applicable" #4
- How I did it

- How to verify it
set led for fan/psu and then check
get fan direction
test-led-fandir.txt

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

…ices

platform/mellanox/mlnx-platform-api/sonic_platform/fan.py

platform/mellanox/mlnx-platform-api/sonic_platform/psu.py

platform/mellanox/mlnx-platform-api/sonic_platform/fan.py

platform/mellanox/mlnx-platform-api/sonic_platform/psu.py

liat-grozovik

How do you test the below code?
Did you add a new test in sonic-mgmt to verify it? if not, unit testing?

platform/mellanox/mlnx-platform-api/sonic_platform/chassis.py

platform/mellanox/mlnx-platform-api/sonic_platform/fan.py

… 1 for now.

stephenxs · 2019-11-26T23:47:20Z

community PR #3795 opened,

* src/sonic-telemetry fa8d498...3bd7ca3 (4): > Update gnmi deps (#40) > [testdata] Update SFP keys to align with new standard (#39) > Fixed the parameters for subscribe APIs (#38) > Azure ro mode (#34) * src/sonic-mgmt-common 444aa9a...cc01ce4 (4): > Make gnmi dep version the same as in telemetry repo (#17) > Cleanup translib and cvl go test cases (#13) > Package update and enhancements/fixes in YGOT, and Request Binder (#12) > Translib phase I changes (#11) Note: sonic-telemetry submodule update is dependent upon sonic-mgmt-common submodule update, thus updating both in this patch

* src/sonic-ztp c959371...dd025bc (2): > Update all references to new 'sonic-installer' file name (#18) > Filter out non-printable characters read from syseeprom (#17)

* [BFN] Updated platform APIs impl Signed-off-by: Andriy Kokhan <[email protected]> * Extended BFN platform SFP APIs implementation * Update sfp.py * [BFN] Extended SFP platform plugin implementation Signed-off-by: Andriy Kokhan <[email protected]> * [BFN] Extended Fans platform plugin implementation * [BFN] divided classes Fan and FanDrawer into 2 files * Signed-off-by: Vadym Yashchenko <[email protected]> What I did Add get_model() function Add get_low_critical_threshold() function Change __get(...) function. How I did it Differnece from previous implementation of __get(...) function is return real value or -9999.9 if value is not provided by thrift API * Add get_presence() function and revised __get() function Signed-off-by: Vadym Yashchenko <[email protected]> * [BFN] Updated PSU platform APIs impl Signed-off-by: Dmytro Lytvynenko <[email protected]> * Added BFN PSU cache (#9) Signed-off-by: Andriy Kokhan <[email protected]> * [BFN] Fans and Fantray platform APIs update (#7) * [BFN] Updated SFP platform APIs (#10) Signed-off-by: Volodymyr Boyko <[email protected]> * [BFN] Updated platform API for thermal (#8) * Signed-off-by: Vadym Yashchenko <[email protected]> * Revert "[BFN] Fans and Fantray platform APIs update (#7)" (#11) This reverts commit c62a733. * Add support health monitor system (#15) Signed-off-by: Petro Bratash <[email protected]> * Update chassis.py * [BFN] Updated FANs and FAN Tray platform API (#14) * Fix fix_alignment (#17) Signed-off-by: Petro Bratash <[email protected]> * [BFN] Improvement show environment (#16) * Added PSU temperature skip into platform.json (#18) Signed-off-by: Andriy Kokhan <[email protected]> * Do not skip psud on Newport Signed-off-by: Andriy Kokhan <[email protected]> * [BFN] fix fan status from Not OK to Ok (#19) * [BFN] Updated SFP platform plugin (#13) Signed-off-by: Volodymyr Boyko <[email protected]> * [DPB] Fix typo for Ethernet0 2x200G[100G,40G] breakout mode (#21) Signed-off-by: Mykola Gerasymenko <[email protected]> * [barefoot] Tmp fix vendor_rev (#22) Signed-off-by: Volodymyr Boyko <[email protected]> * Fixed python issues in sonic_platform/fan_drawer.py Signed-off-by: Andriy Kokhan <[email protected]> * Updated fan_drawer.py * Fixing trailing white spaces in fan_drawer.py * [BFN] Fix thrift for SFPs API Signed-off-by: Volodymyr Boyko <[email protected]> * In platform.json, replaced 'false' with '0' to workaround ast.literal_eval() issue Signed-off-by: Andriy Kokhan <[email protected]> * [Newport] Thermal manager (#23) * Signed-off-by: Vadym Yashchenko <[email protected]> * Revert "In platform.json, replaced 'false' with '0' to workaround ast.literal_eval() issue" This reverts commit 1e73127. * Removed 'controllable' options from platform.json to fix factory default config generation Signed-off-by: Andriy Kokhan <[email protected]> * Update thermal_manager.py * Migrated SFP plugin to sonic_xcvr API (#30) Signed-off-by: Andriy Kokhan <[email protected]> Co-authored-by: KostiantynYarovyiBf <[email protected]> Co-authored-by: Vadym Yashchenko <[email protected]> Co-authored-by: Dmytro Lytvynenko <[email protected]> Co-authored-by: Volodymyr Boiko <[email protected]> Co-authored-by: Petro Bratash <[email protected]> Co-authored-by: Mykola Gerasymenko <[email protected]>

[sonic-linkmgrd][master] submodule update ef1f5eb Jing Zhang Feb 3 09:37:25 2022 [linkmgrd] linkmgrd subscribes MUX_CABLE_INFO table to handle peer OIR events (#17) bcd74b4 Jing Zhang Feb 1 09:52:00 2022 Collect ICMP packet loss information (#14) sign-off: Jing Zhang [email protected]

[sonic-linkmgrd][202012] submodule update ef1f5eb Jing Zhang Feb 3 09:37:25 2022 [linkmgrd] linkmgrd subscribes MUX_CABLE_INFO table to handle peer OIR events (#17) bcd74b4 Jing Zhang Feb 1 09:52:00 2022 Collect ICMP packet loss information (#14) sign-off: Jing Zhang [email protected]

…tically (sonic-net#18017) #### Why I did it src/sonic-dash-api ``` * ec15bc7 - (HEAD -> master, origin/master, origin/HEAD) Revert "rename VnetMapping.action_type" (#17) (2 hours ago) [Ze Gan] * ad0f59e - Add unspecified default value to all enums (2 days ago) [Lawrence Lee] * dd844b1 - Merge branch 'add-enum-default' of github.com:theasianpianist/sonic-dash-api into add-enum-default (4 days ago) [Lawrence Lee] |\ | * 4b31135 - Merge branch 'master' into add-enum-default (4 days ago) [Lawrence Lee] * | 4b41ea7 - rename VnetMapping.action_type (4 days ago) [Lawrence Lee] |/ * b1ab99f - Add unspecified default value to all enums (4 days ago) [Lawrence Lee] ``` #### How I did it #### How to verify it #### Description for the changelog

* Update to Linux 6.1.94 * Integrate HW-MGMT 7.0040.1008 Changes (#17) * Update DNX kernel module build * Update kernel and saibcm-modules-dnx to versions on branch Signed-off-by: Saikrishna Arcot <[email protected]> Co-authored-by: Vivek <[email protected]>

…7250E platform (sonic-net#20367) Update sonic-platform submodule for Nokia-IXR7250E: Fixes Nokia-ION/ndk#57 cdfbbe2 [H4-32D]Update platform modules after OC tests (Update README.md #17) f28eff0 [H4-64D]Fix SFP+ port, eeprom, reboot-cause, thermal algorithm, add PSU input voltage check (Fix rules in Makefiles #15) 178e15a Minor watchdog change for better retention of last kick stamp c479392 Remove rogue platform_reboot file 331abe0 Enhance watchdog script to detect fsde device hung signature 4c6b7c1 Fixed update temperature issue 5002fb7 Remove average and maximum c620130 No PSU Master status led in IMM. No need to set it Signed-off-by: mlok <[email protected]>

…net#25643) * [build] Add build timing report and dependency analysis tools Add three scripts for build performance instrumentation: - scripts/build-timing-report.sh: Parse per-package timing from build logs (HEADER/FOOTER timestamps), generate sorted duration table, phase breakdown, parallelism timeline, and CSV export. - scripts/build-dep-graph.py: Parse rules/*.mk dependency graph, compute critical path, fan-out/fan-in bottleneck analysis, and generate DOT/JSON output for visualization. - scripts/build-resource-monitor.sh: Sample CPU, memory, disk I/O, and Docker container count during builds for resource utilization analysis. Add "make build-report" target to slave.mk that runs the timing report and dependency analysis after a build completes. Example output from a VS build on 24-core/30GB machine: - 210 packages built in 53m wall time (173m CPU) - Max concurrency: 5 (with SONIC_CONFIG_BUILD_JOBS=4) - Critical path: 14 packages deep (libnl -> libswsscommon -> utilities) - Top bottleneck: LIBSWSSCOMMON with 48 downstream dependents Signed-off-by: Rustiqly <[email protected]> * Address Copilot review: fix 17 bugs in build analysis scripts - Use free -m with division instead of free -g to avoid rounding (#1) - Add = and ?= to Makefile dependency regex patterns (#2, #7) - CPU calculation now uses /proc/stat delta (two reads) (#3, #14) - Fix misleading 'critical path estimate' comment (#4) - Fix parallelism timeline comment (60s not 10s) (#5) - Include after-relationship packages in fan stats (#6) - Guard disk I/O division by zero when INTERVAL<=1 (#8) - Remove unused elapsed_line variable (#9) - Remove redundant LIBSWSSCOMMON_DBG check (#10) - Remove active_make_jobs from CSV header comment (#11) - Wire up _RDEPENDS parsing to build reverse deps (#12) - Remove unnecessary 'if v' filter on rdeps JSON (#13) - Remove unused REPORT_FORMAT parameter (#15) - Add cycle detection to critical path algorithm (#16) - Add execute permission check for companion scripts (#17) Signed-off-by: Rustiqly <[email protected]> --------- Signed-off-by: Rustiqly <[email protected]> Co-authored-by: Rustiqly <[email protected]>

[sonic_platform]support led for fan/psu and fan direction on SPC2 dev…

c202771

…ices

keboliu requested changes Nov 20, 2019

View reviewed changes

liat-grozovik suggested changes Nov 20, 2019

View reviewed changes

Stephen Sun added 2 commits November 20, 2019 09:16

[sonic_platform]address comments

3b5507b

[sonic_platform]address comments

b50b64f

keboliu approved these changes Nov 21, 2019

View reviewed changes

[sonic_platform]fix typo

2a78ca2

liat-grozovik reviewed Nov 24, 2019

View reviewed changes

platform/mellanox/mlnx-platform-api/sonic_platform/chassis.py Show resolved Hide resolved

platform/mellanox/mlnx-platform-api/sonic_platform/chassis.py Outdated Show resolved Hide resolved

platform/mellanox/mlnx-platform-api/sonic_platform/fan.py Show resolved Hide resolved

Stephen Sun added 2 commits November 24, 2019 16:00

[sonic_platform]fix typo: fan's direction isn't supported on spectrum…

59b7fcb

… 1 for now.

[sonic_platform]rename the spectrum chip id

19fd4c6

liat-grozovik approved these changes Nov 26, 2019

View reviewed changes

stephenxs closed this Nov 26, 2019

stephenxs pushed a commit that referenced this pull request Aug 8, 2020

[sonic-ztp] Update submodule (sonic-net#5120)

6b72dee

* src/sonic-ztp c959371...dd025bc (2): > Update all references to new 'sonic-installer' file name (#18) > Filter out non-printable characters read from syseeprom (#17)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Mellanox]support led for fan/psu and fan direction#17

[Mellanox]support led for fan/psu and fan direction#17
stephenxs wants to merge 6 commits intomasterfrom
led-fan_dir

stephenxs commented Nov 20, 2019 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

liat-grozovik left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stephenxs commented Nov 26, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

stephenxs commented Nov 20, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

liat-grozovik left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stephenxs commented Nov 26, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

stephenxs commented Nov 20, 2019 •

edited

Loading