Skip to content

[Mellanox]support led for fan/psu and fan's direction#3795

Merged
jleveque merged 7 commits intosonic-net:masterfrom
stephenxs:led-fan_dir
Dec 4, 2019
Merged

[Mellanox]support led for fan/psu and fan's direction#3795
jleveque merged 7 commits intosonic-net:masterfrom
stephenxs:led-fan_dir

Conversation

@stephenxs
Copy link
Collaborator

- What I did
support led for fan/psu and fan direction
It depends on add fan direction "not applicable" #67
- How I did it
Fetch that information from sysfs.

- How to verify it
set led for fan/psu and then check
get fan direction
test-led-fandir.txt

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)


FAN_PATH = "/var/run/hw-management/thermal/"
LED_PATH = "/var/run/hw-management/led/"
# fan_dir only exist Spectrum 2 switches
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the comment that it is currently not supported in spectrum 1 and later new Silicon should not be addressed and will have it supported by default

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed.

@stephenxs
Copy link
Collaborator Author

retest this, please

1 similar comment
@stephenxs
Copy link
Collaborator Author

retest this, please

@stephenxs
Copy link
Collaborator Author

retest this, please

@jleveque
Copy link
Contributor

jleveque commented Dec 4, 2019

Retest vsimage please

@jleveque jleveque merged commit d5aa0d4 into sonic-net:master Dec 4, 2019
@stephenxs stephenxs deleted the led-fan_dir branch December 7, 2019 11:06
mssonicbld added a commit that referenced this pull request Mar 10, 2025
…atically (#21976)

#### Why I did it
src/sonic-utilities
```
* fd43d51 - (HEAD -> master, origin/master, origin/HEAD) Fixes `show interface transceiver info Ethernet0` command failure for CMIS SFP. (#3795) (4 hours ago) [AZ]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants