Add error handling for Search Asset results #2389

leofelix077 · 2025-11-18T21:38:24Z

429 is hard to reproduce, as it depends on GitHub returning the 429 or not , so the network error was mocked to be cancelled to simulate the error state and early return + Unit tests added for the scenarios

before.mov

after.mov

* upgrade to yarn 2 and use resolutions to block vulnerable package versions (#2239) * upgrade to yarn 2 and use resolutions to block vulnerable package versions * rm deprecated .yarnrc * rm yarnpath * try committing yarn binary to repo * try corepack enable for gha * update run tests cmd * rm yarnpath * rm npm i yarn * update all pipelines * rm superfluous history types * ensure invoke host function tx shows contract parameters (#2243) * ensure invoke host function tx shows contract parameters * add test for fallback if contract spec retrieval fails * Bugfix/rm auth param names (#2244) * ensure invoke host function tx shows contract parameters * add test for fallback if contract spec retrieval fails * do not show contract parameters for authorizations * add tests for create contract v1 and invoke contract * add issuer for changeTrust op (#2246) * add issuer for changeTrust op * programmatically disable overflow:hidden when copying a value * Revert "add issuer for changeTrust op (#2246)" (#2247) This reverts commit 19c8a68. * Bugfix/add issuer for changetrust (#2249) * ensure invoke host function tx shows contract parameters * add test for fallback if contract spec retrieval fails * do not show contract parameters for authorizations * add tests for create contract v1 and invoke contract * add issuer for changeTrust op * programmatically disable overflow:hidden when copying a value * cache account balances and poll for updates * fix CI tests * rm `force:true` which was causing action to happen too fast * do a fresh balance fetch on account/network change * first pass at async history * pr comments * allow for history caching * add more sentry tracking for Account and Wallets views (#2268) * add more sentry tracking for Account and Wallets views * adding more sentry reporting * gracefully degrade on errors from Blockaid (#2269) * gracefully degrade on errors from Blockaid * should not be necessary to skip dapp scanning on custom network * rm extra dep * add a test for persisting configurations in the send flow (#2271) * add a test for persisting configurations in the send flow * rm logs and update muxed acct; lower xlm payment * rm slow loading simulation * handle missing scan-tx result; add disabled state for Confirm Anyway (#2272) * handle missing scan-tx result; add disabled state for Confirm Anyway * assertions to show correct confirm button on Blockaid error * add cache for balances to ensure we do a fresh lookup when needed (#2275) * add cache for balances to ensure we do a fresh lookup when needed * add try...catch to token-prices polling * rm log * only dispatch saveBalancesForAccount when fresh data has been fetched * adjust test to wait for UI change * replace yarn setup with just yarn * rm unnecessary return * clear token details on redux clear action * make history row construction async and check for redux state for updates * add tests for assetdetails * increase timeout for flakey test * pr comments * refresh account history every time account balances refresh

* check for updated appdata before showing password modal * update error msg * rm unused redirect logic

* move get icons out of critical path; rely on background's cache * add tests and comments * add comment * add comment * only dispatch if we have cached icons * PR comments

* skip blockaid scan on first fetch of account-balances * rm stub change * rm more stubs * rm log * add comments and update boolean naming

* add button to copy address from dropdown * Added translations * revert translation file changes * revert translation file changes * Added translations * revert changes to translation files * move copy address button to first dropdown position

* scroll on long strings; pretty print json * rm log * add correct snapshot for json message * rm log * finish comment * add error case for JSON * don't use carat for lib * update yarn.lock * move scrollbar to btm of container; reduce json font size * update snapshot

* re-searching so should abort any in flight API requests * add comment * fix test name * make test more reliable * add check for correct search results * fix jest locator

* adds SelectionTile and AddressTile, updates nav flows to match updates. Adds query parameter for default values in send flow * Added translations * adds address tile and uses it in swap flow, tweaks selection tile styles * adds unit tests for new tile components * Added translations * updates swap navigation flow to match updates, updates tests flows to match * updates back icon for send and swap steps, fixes bad test references * tweaks locator in address tile tests * adds store state to asset tile tests, removes asset icon mock * updates SelectionTile prop name, adds isSuspicious prop for AssetTile * adds placeholder value in TokenList for missing token USD value * uses real IdenticonImg in address tile unit tests * adds query param validation for send and swap flow * Update extension/src/popup/views/SendPayment/index.tsx Co-authored-by: Cássio Marcos Goulart <[email protected]> * adds missing import * adds class for tile icon --------- Co-authored-by: Cássio Marcos Goulart <[email protected]>

* adds send and swap buttons to asset detail view * uses secondary button styles * removes run snapshots job (#2355) * release/5.35.4 (#2354) * upgrade to ledger-hq/hw-transport-webhid (#2350) * upgrade to ledger-hq/hw-transport-webhid * add tests * add ledger support for new trustline flow (#2352) * upgrade to ledger-hq/hw-transport-webhid * add ledger support for new trustline flow * only re-fetch balances if we were successful * test for fetching balances on success * add reset spys * adjust spacing at top of hw wallet modal * Now that `Done` button properly shows, click it in tests (#2356) * skip flakey test * skip flakey test * renames local vars to follow convention * adds tests for LP share and tweaks LP title * adds links with query params for asset detail CTAs --------- Co-authored-by: Piyal Basu <[email protected]>

* only fetch asset list data if needed * correctly show icon loading state

* adds SAC detection when changing trust in the add and remove token flows * updates arg signature for isAssetSac

# Conflicts: # extension/src/popup/locales/en/translation.json # extension/src/popup/locales/pt/translation.json

* cache token prices and batch loading wallets * use similar methodology for token price and account balance caching * fix loading state trigger * fix tests * use helper for cache clearing * set isFetchingTokenPrices to false in catch handler * rollback error change

* load backend settings async on Account view * rm console.logs

* use ledger-key/accounts endpoint for home domains * fix tests * create generic ledger key account helper; add tests * rm unneeded data-test prop * rm unused import * [CHORE] git process updates (#2361) * moves the add translations hook to the pre commit stage, removes standalone translations commit * adds script to update app version, removes version update from submit production action, adds update version step to test run action for release branches * removes version input, now uses package version * fetch asset domains in one calls * fix tests * cache home domains while iterating over account history rows * fitler non-G keys * rm .only * fix test param * PR comments --------- Co-authored-by: aristides <[email protected]>

leofelix077 · 2025-11-21T18:12:54Z

extension/package.json

    "@types/react-redux": "7.1.34",
    "@types/react-router-dom": "5.3.3",
    "@types/redux": "3.6.31",
-    "@types/testing-library__jest-dom": "6.0.0",


deprecated was causing tsc issues

piyalbasu · 2025-11-24T19:03:22Z

extension/src/popup/helpers/searchAsset.ts

-        }
-      }
+    const matchingRecord = data.assets?.find(
+      (record) => record.contract === contractId,


the above ignores case for the contract ID while the new line explicitly expects the same exact string. We should preserve this to guard against cases where (for ex) a user forgets to capitalize a letter of a contract ID. A very edge case - but unless there's a strong reason to remove this, let's maintain it

piyalbasu · 2025-11-24T19:48:41Z

extension/src/popup/helpers/__tests__/searchAsset.test.js


    // error for missing `name` and error for additional key `title`
-    expect(errors).toHaveLength(2);
+    expect(errors).toHaveLength(3);


Looks like the 3rd error is for the extra key feedback. Mind adding that to the comment on ln 145?

piyalbasu · 2025-11-24T20:17:45Z

extension/src/popup/views/SignTransaction/hooks/useGetSignTxData.tsx

+              icons[canonical] = cachedIcon;
            } else {
-              let icon = await getIconUrlFromIssuer({
+              let icon: string | null = await getIconUrlFromIssuer({


why change the type here? getIcornUrlFromIssuer can only return a string

piyalbasu · 2025-11-24T20:20:39Z

extension/src/popup/views/SignTransaction/hooks/useGetSignTxData.tsx

+      const icons = {} as { [code: string]: string };
+      // Initialize with cached lists, but we'll fetch fresh data when needed for icon lookups
+      let assetsListsData: AssetListResponse[] = cachedTokenLists || [];
+      let hasFetchedAssetLists = false;


should this be hasFetchedAssetLists = assetsListsData.length > 0? Looks like you could already have the assetLists if cachedTokenLists is populated

piyalbasu · 2025-11-24T20:30:02Z

@shared/api/helpers/token-list.ts

+  cachedAssetLists?: AssetListResponse[];
 }) => {
+  // If cached asset lists are provided and not empty, use them instead of fetching
+  if (cachedAssetLists?.length) {


can we add a test for this?

piyalbasu

Nice! This approach is what I was thinking when I made my original comment. This is looking good. I left a couple of NIT comments, but otherwise, this PR lgtm

…gfix/unblock-asset-list-on-429

piyalbasu and others added 20 commits October 7, 2025 15:45

check for updated appdata before showing password modal (#2300)

b61ec65

* check for updated appdata before showing password modal * update error msg * rm unused redirect logic

stringify errors rather than using cause (#2302)

91a49a5

Feature/move icons to own hook (#2308)

cc130fc

* move get icons out of critical path; rely on background's cache * add tests and comments * add comment * add comment * only dispatch if we have cached icons * PR comments

skip blockaid scan on first fetch of account-balances (#2310)

c50cbc1

* skip blockaid scan on first fetch of account-balances * rm stub change * rm more stubs * rm log * add comments and update boolean naming

Merge branch 'master' into release/5.36.0

89b00b0

Merge branch 'master' into release/5.36.0

9218e3f

re-searching so should abort any in flight API requests (#2323)

077117e

* re-searching so should abort any in flight API requests * add comment * fix test name * make test more reliable * add check for correct search results * fix jest locator

only fetch asset list data if needed (#2369)

5199754

* only fetch asset list data if needed * correctly show icon loading state

[BUG] SAC token management improvements (#2374)

cdafa95

* adds SAC detection when changing trust in the add and remove token flows * updates arg signature for isAssetSac

Merge branch 'master' into release/5.36.0

85014fb

# Conflicts: # extension/src/popup/locales/en/translation.json # extension/src/popup/locales/pt/translation.json

load backend settings async on Account view (#2381)

6268562

* load backend settings async on Account view * rm console.logs

update version numbers for release

9a0dd5e

Eadd error handling for soroswap tokenlist.json fail state

151770c

leofelix077 self-assigned this Nov 18, 2025

leofelix077 added wip not for merging yet don't review yet wip / tests in progress / missing videos or screenshots / pending self code-review labels Nov 18, 2025

leofelix077 changed the title ~~Add error handling for Search Asset results~~ [WIP/DNR] Add error handling for Search Asset results Nov 18, 2025

extract schema into constant

4849a32

leofelix077 removed wip not for merging yet don't review yet wip / tests in progress / missing videos or screenshots / pending self code-review labels Nov 19, 2025

leofelix077 requested review from aristidesstaffieri and piyalbasu November 19, 2025 14:12

leofelix077 changed the title ~~[WIP/DNR] Add error handling for Search Asset results~~ Add error handling for Search Asset results Nov 19, 2025

update getTokenFromTokenList

48ca0e7

leofelix077 reopened this Nov 21, 2025

leofelix077 added 3 commits November 21, 2025 14:00

update token list fetch parallel

4927799

update token list fetch parallel

ed9ca12

remove manual definition of verified tokens

607bb7c

leofelix077 marked this pull request as draft November 21, 2025 17:12

revert to parallel fetch on getAssets

6725607

leofelix077 closed this Nov 21, 2025

revert to parallel fetch on getAssets

a3cc0a7

leofelix077 reopened this Nov 21, 2025

leofelix077 added 4 commits November 21, 2025 14:19

revert to parallel fetch on getAssets

dc8184d

update tests for error handling

663c8d5

update tests for error handling

b658a3f

remove deprecated package

4c9da4f

leofelix077 commented Nov 21, 2025

View reviewed changes

leofelix077 removed the don't review yet wip / tests in progress / missing videos or screenshots / pending self code-review label Nov 21, 2025

leofelix077 marked this pull request as ready for review November 21, 2025 18:20

piyalbasu reviewed Nov 24, 2025

View reviewed changes

Base automatically changed from release/5.36.0 to master November 24, 2025 20:31

piyalbasu approved these changes Nov 24, 2025

View reviewed changes

leofelix077 closed this Nov 25, 2025

leofelix077 reopened this Nov 26, 2025

leofelix077 changed the base branch from master to release/5.37.0 November 26, 2025 13:24

leofelix077 added 3 commits November 26, 2025 10:27

Merge branch 'release/5.37.0' of github.com:stellar/freighter into bu…

884726d

…gfix/unblock-asset-list-on-429

add tests for cached list and comments on functions

1d9880a

fix tests

de381a6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add error handling for Search Asset results #2389

Add error handling for Search Asset results #2389

Uh oh!

leofelix077 commented Nov 18, 2025 •

edited

Loading

Uh oh!

leofelix077 Nov 21, 2025

Uh oh!

piyalbasu Nov 24, 2025

Uh oh!

piyalbasu Nov 24, 2025

Uh oh!

piyalbasu Nov 24, 2025

Uh oh!

piyalbasu Nov 24, 2025

Uh oh!

piyalbasu Nov 24, 2025

Uh oh!

piyalbasu left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Add error handling for Search Asset results #2389

Are you sure you want to change the base?

Add error handling for Search Asset results #2389

Uh oh!

Conversation

leofelix077 commented Nov 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

leofelix077 Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

piyalbasu Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

piyalbasu Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

piyalbasu Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

piyalbasu Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

piyalbasu Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

piyalbasu left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

leofelix077 commented Nov 18, 2025 •

edited

Loading