Feature/move history fetch to bg #2273

piyalbasu · 2025-09-26T17:40:52Z

This removes retrieving /account-history from the blocking path on Account load. This call can be one of the larger payloads to retrieve in a long line of requests. On my test account, this makes the Account view load about 500ms for me 🎉. As with the /account-balances refactor, these are all cumulative changes to chip away at sluggish loading times. Once i complete #2258, I'll post a video showing a before and after view of streamlining all of these calls

…sions (#2239) * upgrade to yarn 2 and use resolutions to block vulnerable package versions * rm deprecated .yarnrc * rm yarnpath * try committing yarn binary to repo * try corepack enable for gha * update run tests cmd * rm yarnpath * rm npm i yarn * update all pipelines * rm superfluous history types

* ensure invoke host function tx shows contract parameters * add test for fallback if contract spec retrieval fails

* ensure invoke host function tx shows contract parameters * add test for fallback if contract spec retrieval fails * do not show contract parameters for authorizations * add tests for create contract v1 and invoke contract * add issuer for changeTrust op (#2246) * add issuer for changeTrust op * programmatically disable overflow:hidden when copying a value * Revert "add issuer for changeTrust op (#2246)" (#2247) This reverts commit 19c8a68.

* ensure invoke host function tx shows contract parameters * add test for fallback if contract spec retrieval fails * do not show contract parameters for authorizations * add tests for create contract v1 and invoke contract * add issuer for changeTrust op * programmatically disable overflow:hidden when copying a value

piyalbasu · 2025-09-26T17:43:48Z

extension/src/popup/components/account/AssetDetail/index.tsx

-              </>
-            </div>
-          ) : (
+          {assetOperations === null ? (


if we are in the rare case where a user tries to view their Asset Details, but history has not finished loading yet, this allows us to just show a until that request finishes

Screen.Recording.2025-09-26.at.1.52.00.PM.mov

Simulation of what a slow loading history would look like

piyalbasu · 2025-09-26T17:44:42Z

extension/src/popup/ducks/cache.ts

+  };
+  historyData: {
+    [network: string]: Record<PublicKey, HistoryResponse>;
+  };


let's cache tokenDetails and historyData. tokenDetails are unlikely to change, but we can refresh historyData as needed

piyalbasu · 2025-09-26T17:46:05Z

extension/src/popup/views/Account/hooks/useGetAccountData.tsx

        !shouldForceBalancesRefresh,
      );

-      const history = await fetchHistory(publicKey, networkDetails);


removing history fetch from the blocking path when loading Account

extension/src/popup/views/Account/index.tsx

* add more sentry tracking for Account and Wallets views * adding more sentry reporting

* gracefully degrade on errors from Blockaid * should not be necessary to skip dapp scanning on custom network * rm extra dep

* add a test for persisting configurations in the send flow * rm logs and update muxed acct; lower xlm payment

…2272) * handle missing scan-tx result; add disabled state for Confirm Anyway * assertions to show correct confirm button on Blockaid error

) * add cache for balances to ensure we do a fresh lookup when needed * add try...catch to token-prices polling * rm log * only dispatch saveBalancesForAccount when fresh data has been fetched

# Conflicts: # extension/src/popup/ducks/cache.ts # extension/src/popup/views/Account/hooks/useGetAccountData.tsx

…ates

piyalbasu · 2025-10-03T21:27:06Z

extension/src/helpers/hooks/useTokenDetails.tsx

+        For example, when constructing the history rows, this hook can be called many times as we iterate over the history items. 
+        If we have cached token details earlier in the loop, we won't have access to the update redux state until the next render.
+        To workaround this, we will also check the redux state manually here rather than waiting for the next render to 
+        update the selector hook for us.


Example: In my account history, I have 10 transfers using the same custom token. The getHistoryData hook will run once on first render and then call this method 10 times as we iterate over the history items. However, because we're still in the first render, the useSelector hook won't have access to the updated redux state yet. This will result in cachedTokenDetails being empty for all 10 iterations, resulting in 10 separate API calls to get the token details.

piyalbasu · 2025-10-06T20:14:01Z

extension/e2e-tests/loadAccount.test.ts

  // make sure we fetch the new balance quickly rather than waiting for the 30 second interval
  await expect(page.getByTestId("asset-amount")).toHaveText("999,111", {
-    timeout: 500,
+    timeout: 3000,


this test is a bit flakey - I believe just waiting a little longer for the UI to re-render should solve this

piyalbasu · 2025-10-06T20:14:19Z

extension/src/helpers/hooks/useGetHistory.tsx

+      const data =
+        useCache && cachedHistoryData
+          ? cachedHistoryData
+          : await getAccountHistory(publicKey, networkDetails);


following a similar pattern to account balance caching

extension/src/helpers/hooks/useTokenDetails.tsx

extension/src/popup/components/account/AssetDetail/index.tsx

extension/src/popup/ducks/cache.ts

…/freighter into feature/move-history-fetch-to-bg

piyalbasu · 2025-10-07T17:09:23Z

extension/src/popup/components/account/AssetDetail/index.tsx

    assetIssuer,
  });

-  if (!assetOperations && !isSorobanAsset) {


I'm removing this !isSorobanAsset check. This was added a long time ago here: #738

This was supposed to be blocking showing history for custom tokens, but wasn't actually working. We can see history for all classic and custom tokens

* Feature/move history fetch to bg (#2273) * upgrade to yarn 2 and use resolutions to block vulnerable package versions (#2239) * upgrade to yarn 2 and use resolutions to block vulnerable package versions * rm deprecated .yarnrc * rm yarnpath * try committing yarn binary to repo * try corepack enable for gha * update run tests cmd * rm yarnpath * rm npm i yarn * update all pipelines * rm superfluous history types * ensure invoke host function tx shows contract parameters (#2243) * ensure invoke host function tx shows contract parameters * add test for fallback if contract spec retrieval fails * Bugfix/rm auth param names (#2244) * ensure invoke host function tx shows contract parameters * add test for fallback if contract spec retrieval fails * do not show contract parameters for authorizations * add tests for create contract v1 and invoke contract * add issuer for changeTrust op (#2246) * add issuer for changeTrust op * programmatically disable overflow:hidden when copying a value * Revert "add issuer for changeTrust op (#2246)" (#2247) This reverts commit 19c8a68. * Bugfix/add issuer for changetrust (#2249) * ensure invoke host function tx shows contract parameters * add test for fallback if contract spec retrieval fails * do not show contract parameters for authorizations * add tests for create contract v1 and invoke contract * add issuer for changeTrust op * programmatically disable overflow:hidden when copying a value * cache account balances and poll for updates * fix CI tests * rm `force:true` which was causing action to happen too fast * do a fresh balance fetch on account/network change * first pass at async history * pr comments * allow for history caching * add more sentry tracking for Account and Wallets views (#2268) * add more sentry tracking for Account and Wallets views * adding more sentry reporting * gracefully degrade on errors from Blockaid (#2269) * gracefully degrade on errors from Blockaid * should not be necessary to skip dapp scanning on custom network * rm extra dep * add a test for persisting configurations in the send flow (#2271) * add a test for persisting configurations in the send flow * rm logs and update muxed acct; lower xlm payment * rm slow loading simulation * handle missing scan-tx result; add disabled state for Confirm Anyway (#2272) * handle missing scan-tx result; add disabled state for Confirm Anyway * assertions to show correct confirm button on Blockaid error * add cache for balances to ensure we do a fresh lookup when needed (#2275) * add cache for balances to ensure we do a fresh lookup when needed * add try...catch to token-prices polling * rm log * only dispatch saveBalancesForAccount when fresh data has been fetched * adjust test to wait for UI change * replace yarn setup with just yarn * rm unnecessary return * clear token details on redux clear action * make history row construction async and check for redux state for updates * add tests for assetdetails * increase timeout for flakey test * pr comments * refresh account history every time account balances refresh * check for updated appdata before showing password modal (#2300) * check for updated appdata before showing password modal * update error msg * rm unused redirect logic * stringify errors rather than using `cause` (#2302) * Feature/move icons to own hook (#2308) * move get icons out of critical path; rely on background's cache * add tests and comments * add comment * add comment * only dispatch if we have cached icons * PR comments * skip blockaid scan on first fetch of account-balances (#2310) * skip blockaid scan on first fetch of account-balances * rm stub change * rm more stubs * rm log * add comments and update boolean naming * Dropdown menu option to copy wallet address (#2316) * add button to copy address from dropdown * Added translations * revert translation file changes * revert translation file changes * Added translations * revert changes to translation files * move copy address button to first dropdown position * scroll on long strings; pretty print json (#2320) * scroll on long strings; pretty print json * rm log * add correct snapshot for json message * rm log * finish comment * add error case for JSON * don't use carat for lib * update yarn.lock * move scrollbar to btm of container; reduce json font size * update snapshot * re-searching so should abort any in flight API requests (#2323) * re-searching so should abort any in flight API requests * add comment * fix test name * make test more reliable * add check for correct search results * fix jest locator * [FEATURE] new send/swap navigation flow (#2353) * adds SelectionTile and AddressTile, updates nav flows to match updates. Adds query parameter for default values in send flow * Added translations * adds address tile and uses it in swap flow, tweaks selection tile styles * adds unit tests for new tile components * Added translations * updates swap navigation flow to match updates, updates tests flows to match * updates back icon for send and swap steps, fixes bad test references * tweaks locator in address tile tests * adds store state to asset tile tests, removes asset icon mock * updates SelectionTile prop name, adds isSuspicious prop for AssetTile * adds placeholder value in TokenList for missing token USD value * uses real IdenticonImg in address tile unit tests * adds query param validation for send and swap flow * Update extension/src/popup/views/SendPayment/index.tsx Co-authored-by: Cássio Marcos Goulart <[email protected]> * adds missing import * adds class for tile icon --------- Co-authored-by: Cássio Marcos Goulart <[email protected]> * [FEATURE] adds send and swap buttons to asset detail view (#2351) * adds send and swap buttons to asset detail view * uses secondary button styles * removes run snapshots job (#2355) * release/5.35.4 (#2354) * upgrade to ledger-hq/hw-transport-webhid (#2350) * upgrade to ledger-hq/hw-transport-webhid * add tests * add ledger support for new trustline flow (#2352) * upgrade to ledger-hq/hw-transport-webhid * add ledger support for new trustline flow * only re-fetch balances if we were successful * test for fetching balances on success * add reset spys * adjust spacing at top of hw wallet modal * Now that `Done` button properly shows, click it in tests (#2356) * skip flakey test * skip flakey test * renames local vars to follow convention * adds tests for LP share and tweaks LP title * adds links with query params for asset detail CTAs --------- Co-authored-by: Piyal Basu <[email protected]> * only fetch asset list data if needed (#2369) * only fetch asset list data if needed * correctly show icon loading state * [BUG] SAC token management improvements (#2374) * adds SAC detection when changing trust in the add and remove token flows * updates arg signature for isAssetSac * Feature/cache token prices (#2373) * cache token prices and batch loading wallets * use similar methodology for token price and account balance caching * fix loading state trigger * fix tests * use helper for cache clearing * set isFetchingTokenPrices to false in catch handler * rollback error change * load backend settings async on Account view (#2381) * load backend settings async on Account view * rm console.logs * Feature/use ledger key for home domains (#2363) * use ledger-key/accounts endpoint for home domains * fix tests * create generic ledger key account helper; add tests * rm unneeded data-test prop * rm unused import * [CHORE] git process updates (#2361) * moves the add translations hook to the pre commit stage, removes standalone translations commit * adds script to update app version, removes version update from submit production action, adds update version step to test run action for release branches * removes version input, now uses package version * fetch asset domains in one calls * fix tests * cache home domains while iterating over account history rows * fitler non-G keys * rm .only * fix test param * PR comments --------- Co-authored-by: aristides <[email protected]> * update version numbers for release * rm unnecessary calls to make flows even faster (#2391) * makes send swap buttons stay in the container in full screen mode (#2392) * makes send swap buttons stay in the container in full screen mode * add a pause to make sure flakey e2e test has time to save changes * use redux selector for allAccounts to properly update rename (#2403) * use redux selector for allAccounts to properly update rename * add longer timeout for flakey btn * Add docs for 5.36.0 (#2408) --------- Co-authored-by: leofelix077 <[email protected]> Co-authored-by: aristides <[email protected]> Co-authored-by: Cássio Marcos Goulart <[email protected]>

piyalbasu added 9 commits September 9, 2025 11:50

ensure invoke host function tx shows contract parameters (#2243)

c5b1ff2

* ensure invoke host function tx shows contract parameters * add test for fallback if contract spec retrieval fails

cache account balances and poll for updates

9e0a758

fix CI tests

ba9a7b2

rm force:true which was causing action to happen too fast

a88c762

do a fresh balance fetch on account/network change

e7a440a

first pass at async history

a2e7cd3

piyalbasu commented Sep 26, 2025

View reviewed changes

extension/src/popup/views/Account/index.tsx Show resolved Hide resolved

Base automatically changed from release/5.35.1 to master October 3, 2025 18:11

piyalbasu added 11 commits October 3, 2025 15:23

pr comments

6b12c5e

allow for history caching

e27c594

add more sentry tracking for Account and Wallets views (#2268)

08e4bb3

* add more sentry tracking for Account and Wallets views * adding more sentry reporting

gracefully degrade on errors from Blockaid (#2269)

6859fe0

* gracefully degrade on errors from Blockaid * should not be necessary to skip dapp scanning on custom network * rm extra dep

add a test for persisting configurations in the send flow (#2271)

d82ace3

* add a test for persisting configurations in the send flow * rm logs and update muxed acct; lower xlm payment

rm slow loading simulation

3bd7f68

handle missing scan-tx result; add disabled state for Confirm Anyway (#…

eca68d2

…2272) * handle missing scan-tx result; add disabled state for Confirm Anyway * assertions to show correct confirm button on Blockaid error

add cache for balances to ensure we do a fresh lookup when needed (#2275

8324043

) * add cache for balances to ensure we do a fresh lookup when needed * add try...catch to token-prices polling * rm log * only dispatch saveBalancesForAccount when fresh data has been fetched

adjust test to wait for UI change

6144ebe

replace yarn setup with just yarn

36b5331

rm unnecessary return

67be1be

piyalbasu force-pushed the feature/move-history-fetch-to-bg branch from 4226ece to 67be1be Compare October 3, 2025 19:25

piyalbasu added 2 commits October 3, 2025 15:29

Merge branch 'master' into feature/move-history-fetch-to-bg

dfcb486

# Conflicts: # extension/src/popup/ducks/cache.ts # extension/src/popup/views/Account/hooks/useGetAccountData.tsx

clear token details on redux clear action

a194f20

piyalbasu marked this pull request as ready for review October 3, 2025 19:39

piyalbasu marked this pull request as draft October 3, 2025 19:40

make history row construction async and check for redux state for upd…

6a11925

…ates

piyalbasu commented Oct 3, 2025

View reviewed changes

piyalbasu added 3 commits October 6, 2025 15:36

add tests for assetdetails

5e91240

increase timeout for flakey test

bf2292b

Merge branch 'master' into feature/move-history-fetch-to-bg

8b64221

piyalbasu commented Oct 6, 2025

View reviewed changes

piyalbasu marked this pull request as ready for review October 6, 2025 20:49

piyalbasu changed the base branch from master to release/5.36.0 October 6, 2025 20:49