Improve metrics handling + make update status uniform#872

Merged

tamalsaha merged 12 commits intomasterfrom

Aug 28, 2019

Contributor

hossainemruz commented Aug 21, 2019 •

edited

Loading

Fixes: #869

Tasks:

Improve metrics handling
Add some necessary labels to the metrics
Make status update handling uniform across all backup/restore host.

hossainemruz and others added 8 commits

August 21, 2019 19:11


          WIP: Improve labels of metrics

20d6c92


          Move storage helper function to kmodules/objectstore-api

fc38087


          refactor

6c744ae


          Make metrics handling + update status uniform

078e08b


          Improve metrics handling + make update status uniform

527fc6b


          Merge branch 'master' of github.com:stashed/stash into metric-label

3be27ba


          Add metrics flag to default functions

fed170b


          Remove metrics flags from pvc functions

9ade706

hossainemruz changed the title ~~Improve labels of metrics~~ Improve metrics handling + make update status uniform

hossainemruz requested review from suaas21 and tamalsaha

August 26, 2019 15:26

hossainemruz marked this pull request as ready for review

August 26, 2019 15:29

hossainemruz mentioned this pull request

Prometheus metrics missing source of the backup #869

Closed


          Add app group as metric label

f7e234a

tamalsaha reviewed

View reviewed changes

pkg/controller/backup_session.go Outdated Show resolved Hide resolved

tamalsaha reviewed

View reviewed changes

pkg/restic/metrics.go Outdated Show resolved Hide resolved

tamalsaha reviewed

View reviewed changes

pkg/restic/metrics.go Show resolved Hide resolved

tamalsaha reviewed

View reviewed changes

pkg/restic/metrics.go Show resolved Hide resolved

tamalsaha reviewed

View reviewed changes

pkg/util/options.go Show resolved Hide resolved

tamalsaha reviewed

View reviewed changes

pkg/restic/metrics.go Outdated Show resolved Hide resolved

hossainemruz added 3 commits

August 28, 2019 15:07


          Don't default serviceAccountName to "default"


          Refactor metrics labels functions

d09e891


          Use Endpoint for REST URL

1b3de9e

hossainemruz requested a review from tamalsaha

August 28, 2019 10:54

tamalsaha approved these changes

View reviewed changes

tamalsaha merged commit f63d5c1 into master

tamalsaha deleted the metric-label branch

August 28, 2019 12:08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet