Prometheus metrics missing source of the backup

[segator]

I am missing more information in the labels of all the metrics stash_*

we need the source of the backup like the PVC we are backing up or the deplomyment/statefulset.
Without this information is useless because we don't know what is success or not.
I'm using autobackup + pvc

For the rest the application is amazing, good job!!

[hossainemruz]

@segator thank you for your feedback. I agree with you. Currently, we set BackupConfiguration name as metric label. I think we should also add target kind and name as label of the metrics.

What else we can improve? What additional metrics you would like to see?

Currently, Stash exports these metrics:
https://appscode.com/products/stash/v0.9.0-rc.0/guides/latest/monitoring/overview/#backup-metrics

[segator]

Hello,
Umh I not sure about that I didn't started playing because principal info is missing,
Maybe I could say i'm miss more information about the repositories.
like type of repository(s3?) name of the repository in all the stash_repository_* or maybe a stash_repository_info with this data.

[hossainemruz]

@segator We have added the following labels to the metrics:

Backup & Restore Metrics Labels:

• driver=Restic|VolumeSnapshotter
• group=apps|kubedb.com
• kind=Deployment|PersistentVolumeClaim|Postgres
• name=my-deploy
• namespace=my-namespace
• repository=gcs-repo

Repository Metrics Labels:

• name=my-repo
• namespace=my-namespace
• backend=gcs|s3|local
• bucket=demo
• prefix=/my/backup/dir

Checkout this PR: #872

[segator]

amazing, when are you going to release new version so I can upgrade my helm?

[hossainemruz]

Probably next week.