Skip to content

feat: make max traceback entries configurable#2370

Open
dorimedini-starkware wants to merge 1 commit into03-21-feat_create_and_use_virtualmachineconfigfrom
03-21-feat_make_max_traceback_entries_configurable
Open

feat: make max traceback entries configurable#2370
dorimedini-starkware wants to merge 1 commit into03-21-feat_create_and_use_virtualmachineconfigfrom
03-21-feat_make_max_traceback_entries_configurable

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

@dorimedini-starkware dorimedini-starkware commented Mar 23, 2026

TITLE

Description

Description of the pull request changes and motivation.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

This change is Reviewable

@dorimedini-starkware dorimedini-starkware self-assigned this Mar 23, 2026
@dorimedini-starkware dorimedini-starkware marked this pull request as ready for review March 23, 2026 09:11
@dorimedini-starkware dorimedini-starkware force-pushed the 03-21-feat_create_and_use_virtualmachineconfig branch from d952600 to 68f9328 Compare March 23, 2026 09:18
@dorimedini-starkware dorimedini-starkware force-pushed the 03-21-feat_make_max_traceback_entries_configurable branch from 760fe16 to 4183462 Compare March 23, 2026 09:18
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 23, 2026

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.125 ± 0.020 2.102 2.170 1.02 ± 0.01
head big_factorial 2.090 ± 0.022 2.072 2.139 1.00
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.051 ± 0.015 2.039 2.090 1.01 ± 0.01
head big_fibonacci 2.028 ± 0.013 2.012 2.057 1.00
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 7.270 ± 0.077 7.207 7.481 1.02 ± 0.02
head blake2s_integration_benchmark 7.142 ± 0.114 7.037 7.394 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.175 ± 0.012 2.163 2.198 1.02 ± 0.01
head compare_arrays_200000 2.134 ± 0.009 2.116 2.150 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.427 ± 0.018 1.414 1.476 1.01 ± 0.02
head dict_integration_benchmark 1.414 ± 0.013 1.405 1.449 1.00
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.214 ± 0.007 1.206 1.226 1.01 ± 0.01
head field_arithmetic_get_square_benchmark 1.199 ± 0.005 1.194 1.209 1.00
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 7.355 ± 0.023 7.318 7.388 1.02 ± 0.01
head integration_builtins 7.192 ± 0.071 7.140 7.362 1.00
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 7.417 ± 0.023 7.373 7.441 1.02 ± 0.01
head keccak_integration_benchmark 7.245 ± 0.037 7.205 7.315 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.149 ± 0.009 2.138 2.168 1.01 ± 0.01
head linear_search 2.126 ± 0.013 2.109 2.144 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.502 ± 0.009 1.493 1.524 1.01 ± 0.01
head math_cmp_and_pow_integration_benchmark 1.492 ± 0.006 1.485 1.502 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.459 ± 0.004 1.453 1.463 1.00 ± 0.01
head math_integration_benchmark 1.456 ± 0.017 1.444 1.500 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.212 ± 0.011 1.205 1.243 1.01 ± 0.01
head memory_integration_benchmark 1.206 ± 0.008 1.196 1.224 1.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.541 ± 0.015 1.533 1.584 1.01 ± 0.01
head operations_with_data_structures_benchmarks 1.523 ± 0.005 1.514 1.530 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 530.1 ± 1.0 529.0 531.6 1.01 ± 0.00
head pedersen 527.3 ± 0.9 526.1 529.3 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base poseidon_integration_benchmark 614.6 ± 3.0 611.7 621.9 1.01 ± 0.01
head poseidon_integration_benchmark 605.9 ± 1.0 604.3 607.2 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.812 ± 0.018 1.791 1.848 1.01 ± 0.01
head secp_integration_benchmark 1.787 ± 0.009 1.778 1.806 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 635.9 ± 4.2 633.2 646.1 1.00
head set_integration_benchmark 668.3 ± 1.5 665.4 670.2 1.05 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.177 ± 0.016 4.163 4.217 1.01 ± 0.01
head uint256_integration_benchmark 4.122 ± 0.042 4.096 4.237 1.00

@dorimedini-starkware dorimedini-starkware force-pushed the 03-21-feat_create_and_use_virtualmachineconfig branch from 68f9328 to d2c76cf Compare March 23, 2026 09:50
@dorimedini-starkware dorimedini-starkware force-pushed the 03-21-feat_make_max_traceback_entries_configurable branch 2 times, most recently from 4aaeea4 to 7b560d5 Compare March 23, 2026 09:54
@dorimedini-starkware dorimedini-starkware force-pushed the 03-21-feat_create_and_use_virtualmachineconfig branch from d2c76cf to c30cc6e Compare March 23, 2026 09:54
@dorimedini-starkware dorimedini-starkware force-pushed the 03-21-feat_make_max_traceback_entries_configurable branch from 7b560d5 to 4338e99 Compare March 23, 2026 10:08
@dorimedini-starkware dorimedini-starkware force-pushed the 03-21-feat_create_and_use_virtualmachineconfig branch 2 times, most recently from 0db9b90 to e56b912 Compare March 23, 2026 10:38
@dorimedini-starkware dorimedini-starkware force-pushed the 03-21-feat_make_max_traceback_entries_configurable branch from 4338e99 to de426d9 Compare March 23, 2026 10:38
@dorimedini-starkware dorimedini-starkware force-pushed the 03-21-feat_create_and_use_virtualmachineconfig branch from e56b912 to 91a8238 Compare March 23, 2026 10:49
@dorimedini-starkware dorimedini-starkware force-pushed the 03-21-feat_make_max_traceback_entries_configurable branch 2 times, most recently from 7c90c49 to 6f81c8c Compare March 23, 2026 10:50
@dorimedini-starkware dorimedini-starkware force-pushed the 03-21-feat_create_and_use_virtualmachineconfig branch 2 times, most recently from 499336b to 8064795 Compare March 23, 2026 10:59
@dorimedini-starkware dorimedini-starkware force-pushed the 03-21-feat_make_max_traceback_entries_configurable branch from 6f81c8c to 40f84fa Compare March 23, 2026 10:59
@dorimedini-starkware dorimedini-starkware force-pushed the 03-21-feat_create_and_use_virtualmachineconfig branch from 8064795 to ff35346 Compare March 23, 2026 11:25
@dorimedini-starkware dorimedini-starkware force-pushed the 03-21-feat_make_max_traceback_entries_configurable branch 2 times, most recently from 7a05b43 to c9c23f7 Compare March 25, 2026 13:23
@dorimedini-starkware dorimedini-starkware force-pushed the 03-21-feat_create_and_use_virtualmachineconfig branch from ff35346 to 457de79 Compare March 25, 2026 13:23
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.15%. Comparing base (e49b830) to head (ac18e64).

Additional details and impacted files
@@                               Coverage Diff                               @@
##           03-21-feat_create_and_use_virtualmachineconfig    #2370   +/-   ##
===============================================================================
  Coverage                                           96.14%   96.15%           
===============================================================================
  Files                                                 104      104           
  Lines                                               37540    37565   +25     
===============================================================================
+ Hits                                                36094    36119   +25     
  Misses                                               1446     1446           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dorimedini-starkware dorimedini-starkware force-pushed the 03-21-feat_make_max_traceback_entries_configurable branch from c9c23f7 to 90bc97e Compare March 25, 2026 13:37
@dorimedini-starkware dorimedini-starkware force-pushed the 03-21-feat_create_and_use_virtualmachineconfig branch 2 times, most recently from 00e06c3 to cae34fc Compare March 25, 2026 14:04
@dorimedini-starkware dorimedini-starkware force-pushed the 03-21-feat_make_max_traceback_entries_configurable branch from 90bc97e to 91d5b67 Compare March 25, 2026 14:04
@dorimedini-starkware dorimedini-starkware force-pushed the 03-21-feat_create_and_use_virtualmachineconfig branch from cae34fc to ecfbe1e Compare March 25, 2026 14:38
@dorimedini-starkware dorimedini-starkware force-pushed the 03-21-feat_make_max_traceback_entries_configurable branch from 91d5b67 to 3e6559b Compare March 25, 2026 14:38
@dorimedini-starkware dorimedini-starkware force-pushed the 03-21-feat_create_and_use_virtualmachineconfig branch from ecfbe1e to e49b830 Compare March 25, 2026 15:02
@dorimedini-starkware dorimedini-starkware force-pushed the 03-21-feat_make_max_traceback_entries_configurable branch 2 times, most recently from 6431d86 to ac18e64 Compare March 25, 2026 15:15
Copy link
Copy Markdown
Collaborator

@YairVaknin-starkware YairVaknin-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@YairVaknin-starkware reviewed 8 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on Yael-Starkware).

@dorimedini-starkware dorimedini-starkware force-pushed the 03-21-feat_make_max_traceback_entries_configurable branch from ac18e64 to b653bdc Compare April 9, 2026 19:15
@dorimedini-starkware dorimedini-starkware force-pushed the 03-21-feat_create_and_use_virtualmachineconfig branch from e49b830 to 4fded78 Compare April 9, 2026 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants