Skip to content

feat: move runner_mode to be a field in StwoCairoRunConfig#2366

Open
dorimedini-starkware wants to merge 1 commit into03-21-refactor_rename_cairorunconfig_to_cairo0runconfigfrom
03-21-feat_move_runner_mode_to_be_a_field_in_stwocairorunconfig
Open

feat: move runner_mode to be a field in StwoCairoRunConfig#2366
dorimedini-starkware wants to merge 1 commit into03-21-refactor_rename_cairorunconfig_to_cairo0runconfigfrom
03-21-feat_move_runner_mode_to_be_a_field_in_stwocairorunconfig

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

@dorimedini-starkware dorimedini-starkware commented Mar 23, 2026

TITLE

Description

Description of the pull request changes and motivation.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

This change is Reviewable

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 23, 2026

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.239 ± 0.006 2.231 2.252 1.00
head big_factorial 2.258 ± 0.046 2.241 2.389 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.155 ± 0.008 2.145 2.169 1.00
head big_fibonacci 2.161 ± 0.008 2.153 2.182 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 7.571 ± 0.071 7.510 7.751 1.00
head blake2s_integration_benchmark 7.623 ± 0.112 7.512 7.876 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.271 ± 0.008 2.260 2.280 1.00
head compare_arrays_200000 2.284 ± 0.006 2.275 2.293 1.01 ± 0.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.482 ± 0.012 1.475 1.514 1.00
head dict_integration_benchmark 1.486 ± 0.012 1.477 1.518 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.269 ± 0.014 1.252 1.297 1.01 ± 0.01
head field_arithmetic_get_square_benchmark 1.262 ± 0.007 1.255 1.275 1.00
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 7.782 ± 0.224 7.658 8.409 1.01 ± 0.03
head integration_builtins 7.706 ± 0.048 7.641 7.777 1.00
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 7.866 ± 0.168 7.725 8.219 1.01 ± 0.02
head keccak_integration_benchmark 7.771 ± 0.044 7.724 7.855 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.257 ± 0.021 2.241 2.314 1.00
head linear_search 2.277 ± 0.036 2.248 2.352 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.558 ± 0.005 1.551 1.567 1.00
head math_cmp_and_pow_integration_benchmark 1.568 ± 0.007 1.557 1.580 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.542 ± 0.014 1.528 1.568 1.00
head math_integration_benchmark 1.549 ± 0.017 1.537 1.596 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.287 ± 0.004 1.283 1.292 1.00
head memory_integration_benchmark 1.292 ± 0.006 1.286 1.308 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.642 ± 0.026 1.621 1.705 1.01 ± 0.02
head operations_with_data_structures_benchmarks 1.630 ± 0.010 1.620 1.654 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 567.0 ± 3.8 562.7 572.8 1.00 ± 0.01
head pedersen 564.8 ± 3.2 560.7 568.1 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base poseidon_integration_benchmark 657.6 ± 4.2 651.1 664.3 1.00
head poseidon_integration_benchmark 660.4 ± 7.4 655.1 679.6 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.933 ± 0.007 1.925 1.950 1.00
head secp_integration_benchmark 1.937 ± 0.012 1.926 1.965 1.00 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 660.5 ± 1.8 658.1 664.0 1.00
head set_integration_benchmark 660.9 ± 1.3 659.2 662.6 1.00 ± 0.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.336 ± 0.021 4.300 4.363 1.00
head uint256_integration_benchmark 4.345 ± 0.055 4.302 4.490 1.00 ± 0.01

@dorimedini-starkware dorimedini-starkware force-pushed the 03-21-feat_move_runner_mode_to_be_a_field_in_stwocairorunconfig branch from 4853667 to 8262ccd Compare March 25, 2026 13:23
@dorimedini-starkware dorimedini-starkware force-pushed the 03-21-refactor_rename_cairorunconfig_to_cairo0runconfig branch from a017f6d to 0e1cb53 Compare March 25, 2026 13:23
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.13%. Comparing base (59d1102) to head (c1fa7b8).

Additional details and impacted files
@@                                     Coverage Diff                                     @@
##           03-21-refactor_rename_cairorunconfig_to_cairo0runconfig    #2366      +/-   ##
===========================================================================================
- Coverage                                                    96.13%   96.13%   -0.01%     
===========================================================================================
  Files                                                          104      104              
  Lines                                                        37500    37498       -2     
===========================================================================================
- Hits                                                         36049    36047       -2     
  Misses                                                        1451     1451              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dorimedini-starkware dorimedini-starkware force-pushed the 03-21-feat_move_runner_mode_to_be_a_field_in_stwocairorunconfig branch from 8262ccd to 41e01a7 Compare March 25, 2026 13:37
@dorimedini-starkware dorimedini-starkware force-pushed the 03-21-refactor_rename_cairorunconfig_to_cairo0runconfig branch from 0e1cb53 to 0cebaa3 Compare March 25, 2026 13:37
@dorimedini-starkware dorimedini-starkware force-pushed the 03-21-feat_move_runner_mode_to_be_a_field_in_stwocairorunconfig branch from 41e01a7 to 713a6ed Compare March 25, 2026 14:04
@dorimedini-starkware dorimedini-starkware force-pushed the 03-21-refactor_rename_cairorunconfig_to_cairo0runconfig branch from 0cebaa3 to 3e4a487 Compare March 25, 2026 14:04
@dorimedini-starkware dorimedini-starkware force-pushed the 03-21-feat_move_runner_mode_to_be_a_field_in_stwocairorunconfig branch 2 times, most recently from cc4297e to c1fa7b8 Compare March 25, 2026 15:02
@dorimedini-starkware dorimedini-starkware force-pushed the 03-21-refactor_rename_cairorunconfig_to_cairo0runconfig branch from 0662cae to 59d1102 Compare March 25, 2026 15:02
Copy link
Copy Markdown
Collaborator

@YairVaknin-starkware YairVaknin-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@YairVaknin-starkware reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on Yael-Starkware).

@dorimedini-starkware dorimedini-starkware force-pushed the 03-21-refactor_rename_cairorunconfig_to_cairo0runconfig branch from 59d1102 to 81b2350 Compare April 9, 2026 19:15
@dorimedini-starkware dorimedini-starkware force-pushed the 03-21-feat_move_runner_mode_to_be_a_field_in_stwocairorunconfig branch from c1fa7b8 to 3540366 Compare April 9, 2026 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants