Fixed Asset construction in Collection.from_dict #379
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAugspurger
commented
May 31, 2021
| for asset_key, asset_dict in assets.items(): | ||
| collection.add_asset(asset_key, Asset(asset_dict)) | ||
| asset_dict = dict(asset_dict) | ||
| asset_dict.setdefault("media_type", asset_dict.pop("type", None)) |
Collaborator
Author
There was a problem hiding this comment.
I'll assume it's deliberate that we use media_type here instead of type. Anything else I should watch out for?
Contributor
|
@TomAugspurger I think #373 may have also covered this, sorry for the overlap. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s): #
Closes #378
Description:
Fixed Asset construction in Collection.from_dict
PR Checklist:
scripts/format)scripts/test)