Collection.from_file parses assets incorrectly

[TomAugspurger]

I think that Collection.from_file parses asset objects incorrectly. Given the catalog

{
    "id": "id",
    "stac_version": "1.0.0",
    "type": "Collection",
    "description": "description",
    "license": "license",
    "extent": {
        "temporal": [null, null],
        "spatial": [[null, null]]
    },
    "links": {},
    "assets": {
        "a": {
            "href": "href",
            "title": "tile",
            "description": "description"
        }
    }
}

pystac.Collection.from_file gives

In [12]: pystac.Collection.from_file("cat.json").assets['a'].href
Out[12]: {'href': 'href', 'title': 'tile', 'description': 'description'}

It looks like the whole object is being set for the href, rather than just the href.

[TomAugspurger]

Maybe just missing a ** at

pystac/pystac/collection.py

Line 718 in e90f809

collection.add_asset(asset_key, Asset(asset_dict))

? I'll try that.

[gadomski]

Related to #373.

[TomAugspurger]

Ah missed that. Let's use your PR then, since from_dict is the proper way to do it?

[duckontheweb]

Closed by #373