Document configuration property default for the show-values propertie… #39591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jakesmolka Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@jakesmolka Thank you for signing the Contributor License Agreement! |
spring-projects-issues
added
the
status: waiting-for-triage
Contributor
|
@jakesmolka Thanks for the contribution. PR #39589 was opened just before yours, so I'm afraid we'll need to defer to the other PR. Please keep an eye out for other opportunities to contribute. |
scottfrederick
removed
the
status: waiting-for-triage
mhalbritter
added
the
status: declined
Contributor
Yeah, it's being parsed from the JavaDoc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing: #39565
Dear @mhalbritter and team, I saw the ideal-for-contribution label and just gave it a try. Honestly, since there are just some lines of changes, I'm not sure if that is really what was requested.
Question for my understanding: Is the "When to show unsanitized values." line from the ref doc page parsed from the javadoc comment in the source? This metadata.json file has a
descriptionfield, but not for all entries.Targeting
3.1.xbranch, because of the milestone.(Made a mistake in PR #39590 and created a new one, sorry.)