-
Notifications
You must be signed in to change notification settings - Fork 2
Redesign/semesters #300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Redesign/semesters #300
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
8359dfe
feat: get semesters v2
Hello4545 cbc6a09
feat: get department-options v2
Hello4545 d99b1e1
fix semesters and department-options api
Hello4545 dd3c78b
feat: introduce v2 modules for departments and semesters
sciberbee 082b760
Merge branch 'dev' into redesign/semesters
sciberbee a59dc8f
chore: rearranged v2 interfaces on v2/ directory
sciberbee 1db2d87
revert: revert committed local docker compose file changes
sciberbee 3ce46c1
revert: revert committed local db logging settings
sciberbee dfcc08c
feat: get schedules
Hello4545 63a6d74
Merge branch 'dev' into redesign/semesters
sciberbee 82306e9
refactor: unify filename (no v2) & fix swagger generator
sciberbee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 코드 패치에는 몇 가지 잠재적인 문제가 있습니다. 먼저, 'inferredType' 변수가 'integer', 'number', 'boolean'으로 설정되는 경우에 대한 처리로 인해, 예상치 못한 타입이 반환될 가능성이 있습니다. 'string' 타입이 기본값으로 설정되지만, 'ParseIntPipe'가 존재할 경우에는 'integer'로만 변경되기 때문에, 다른 숫자 또는 불리언 타입이 더 많이 사용될 가능성도 고려해야 합니다. 또한, 파라미터 타입이 'undefined'일 경우를 처리하는 코드는 보이지 않으며, 이러한 경우에 대한 예외 처리 로직이 필요합니다. 마찬가지로, 'decoArgs'가 빈 배열일 경우에도 안전한 처리가 필요합니다. 보안 및 코드 안정성 강화를 위해 더 깨끗한 타입 검증 로직을 고려하고, 최악의 경우 모든 가능한 타입에 대한 처리를 다루는 것이 좋습니다. 마지막으로, 코드 주석이 추가된 것은 좋지만, 코드의 목적이나 사용 규칙을 더 명확히 설명하는 주석이 있으면 좋을 것 같습니다.