[show] Add support for QSFP-DD cables on 'show' command#989
Merged
jleveque merged 2 commits intosonic-net:masterfrom Jul 16, 2020
shlomibitton:shlomi_qsfp_dd
Merged
[show] Add support for QSFP-DD cables on 'show' command#989jleveque merged 2 commits intosonic-net:masterfrom shlomibitton:shlomi_qsfp_dd
jleveque merged 2 commits intosonic-net:masterfrom
shlomibitton:shlomi_qsfp_dd
Conversation
added 2 commits
July 1, 2020 18:35
Signed-off-by: Shlomi Bitton <[email protected]>
…(Application Advertisement)
shlomibitton
changed the title
|
This pull request introduces 1 alert when merging 9296de7 into a23479e - view on LGTM.com new alerts:
|
keboliu
approved these changes
Jul 14, 2020
Contributor
Author
|
retest this please |
Contributor
Author
|
@jleveque please review. |
jleveque
approved these changes
Jul 16, 2020
abdosi
pushed a commit
that referenced
this pull request
Aug 9, 2020
- What I did Add support for QSFP-DD cables on 'sfpshow' script Adapt sfp_test to new eeprom output. - How I did it Added a new label "application_advertisement" to print from DB. Exclude "specification compliance" print from QSFP-DD cables. Signed-off-by: Shlomi Bitton <[email protected]>
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
As part of this commit and previous commit ff6cb6c sonic-utilities submodule for 201911 has been updated to take following changes: Add support for QSFP-DD cables on 'show' command (sonic-net#989) [show] Fix for 'trunk' PortChannel reported as 'routed' port (sonic-net#1002) Enable HW watchdog before fast-reboot (sonic-net#977) [filter-fdb] Check VLAN Presence When Filter FDB (sonic-net#957) (sonic-net#975) [filter-fdb] Fix For Vlan Defined With No CIDR (sonic-net#976) [show/config]: combine feature and container feature cli (sonic-net#1015)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Add support for QSFP-DD cables on 'sfpshow' script
Adapt sfp_test to new eeprom output.
- How I did it
Added a new label "application_advertisement" to print from DB.
Exclude "specification compliance" print from QSFP-DD cables.
- How to verify it
Check for Transceiver DB data with QSFP-DD cable.
Check 'show interfaces transceiver eeprom Ethernet#' output.
Run unit test sfp_test.
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)