Skip to content

[show] Fix for 'trunk' PortChannel reported as 'routed' port#1002

Merged
prsunny merged 2 commits intosonic-net:masterfrom
shlomibitton:shlomi_fix_portchannel_trunk
Jul 30, 2020
Merged

[show] Fix for 'trunk' PortChannel reported as 'routed' port#1002
prsunny merged 2 commits intosonic-net:masterfrom
shlomibitton:shlomi_fix_portchannel_trunk

Conversation

@shlomibitton
Copy link
Copy Markdown
Contributor

Signed-off-by: Shlomi Bitton shlomibi@mellanox.com

- What I did
Changed the output of 'show interfaces status' field related to a PortChannel.
If the PortChannel is a member of a vlan group it will be printed as 'trunk' port instead of default 'routed'.

- How I did it
Check if the PortChannel is a member of a Vlan group and assign a proper tag for it.

- How to verify it

  1. Add a PortChannel to a Vlan group.
  2. Run 'show interfaces status' command.

- Previous command output (if the output of a command-line utility has changed)

PortChannel0005 N/A 100G 9100 N/A N/A routed down up N/A N/A

- New command output (if the output of a command-line utility has changed)

PortChannel0005 N/A 100G 9100 N/A N/A trunk down up N/A N/A

Adding a PortChannel to a Vlan group, will change the 'Vlan' tag to 'trunk'.

Signed-off-by: Shlomi Bitton <shlomibi@mellanox.com>
@shlomibitton
Copy link
Copy Markdown
Contributor Author

retest this please

1 similar comment
@keboliu
Copy link
Copy Markdown
Collaborator

keboliu commented Jul 28, 2020

retest this please

@prsunny prsunny merged commit c6c5be1 into sonic-net:master Jul 30, 2020
abdosi pushed a commit that referenced this pull request Aug 9, 2020
Adding a PortChannel to a Vlan group, will change the 'Vlan' tag to 'trunk'.
Signed-off-by: Shlomi Bitton <shlomibi@mellanox.com>
@shlomibitton shlomibitton deleted the shlomi_fix_portchannel_trunk branch March 24, 2021 20:41
stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this pull request Apr 28, 2022
As part of this commit and previous commit ff6cb6c
sonic-utilities submodule for 201911 has been updated to take following
changes:

 Add support for QSFP-DD cables on 'show' command (sonic-net#989)
 [show] Fix for 'trunk' PortChannel reported as 'routed' port (sonic-net#1002)
Enable HW watchdog before fast-reboot (sonic-net#977)
 [filter-fdb] Check VLAN Presence When Filter FDB (sonic-net#957) (sonic-net#975)
[filter-fdb] Fix For Vlan Defined With No CIDR (sonic-net#976)
 [show/config]: combine feature and container feature cli (sonic-net#1015)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants