Skip to content

[teamshow]: Add teamsohw script to dump all team devices#5

Closed
stcheng wants to merge 1 commit intosonic-net:masterfrom
stcheng:teamshow
Closed

[teamshow]: Add teamsohw script to dump all team devices#5
stcheng wants to merge 1 commit intosonic-net:masterfrom
stcheng:teamshow

Conversation

@stcheng
Copy link
Contributor

@stcheng stcheng commented Feb 9, 2017

No description provided.

lguohan
lguohan reviewed Feb 10, 2017
View reviewed changes
bin/teamshow Outdated
Copy link
Contributor

@lguohan lguohan Feb 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no output, suggest to remove.

Copy link
Contributor Author

@stcheng stcheng Feb 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there're some modificaions from the user. i'll update this output.

bin/teamshow Outdated
Copy link
Contributor

@lguohan lguohan Feb 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there command available outside the teamd docker?

Copy link
Contributor Author

@stcheng stcheng Feb 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. teamdctl has a mock command outside the teamd docker.

bin/teamshow Outdated
Copy link
Contributor

@lguohan lguohan Feb 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of ip link, should we get this from the minigraph? what if teamd failed to create a port channel nedev, then ip link show will not show it.

Copy link
Contributor Author

@stcheng stcheng Feb 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'll update this to use minigraph.

Copy link
Contributor Author

@stcheng stcheng Feb 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in order to use minigraph, i'll also need this #6 to get the alias_map.json file.

@stcheng
Copy link
Contributor Author

stcheng commented Feb 15, 2017

Updated

jleveque
jleveque suggested changes Feb 22, 2017
View reviewed changes
bin/teamshow
def get_alias_map(self):
"""
"""
json_file = open("/etc/ssw/" + self.hwsku + "/alias_map.json").read()
Copy link
Contributor

@jleveque jleveque Feb 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alias_map.json has been deprecated; aliases now reside in port_config.ini.

Copy link
Contributor

@jleveque jleveque Feb 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taoyu just added a new flag to sonic-cfggen in order to obtain the alias map in JSON format. You can just use this line to output a temporary file and reference that:

sonic-cfggen -m /etc/sonic/minigraph.xml -s > /my/temp/location/alias_map.json

lguohan
lguohan reviewed Feb 23, 2017
View reviewed changes
bin/teamshow
self.summary = {}
self.err = None

def get_minigraph(self):
Copy link
Contributor

@lguohan lguohan Feb 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is better way to get the port channel names from minigraph.

https://github.com/Azure/sonic-buildimage/blob/master/dockers/docker-teamd/config.sh

lguohan
lguohan requested changes Feb 23, 2017
View reviewed changes
Copy link
Contributor

@lguohan lguohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not want to see another minigraph parsing logic here. They all should be moved to sonic-cfggen.

@stcheng
Copy link
Contributor Author

stcheng commented Mar 2, 2017

for the output of the command, do we want to display the 'sonic' name e.g. EthernetX, or the alias name e.g. fortyGig0/X?

@stcheng stcheng closed this Mar 3, 2017
samaity added a commit to samaity/sonic-utilities that referenced this pull request Dec 13, 2019
@samaity @zhenggen-xu
Cli Bug fix (sonic-net#5)
46d0b69 
Signed-off-by: Sangita Maity <[email protected]>
vdahiya12 pushed a commit to vdahiya12/sonic-utilities that referenced this pull request Jul 23, 2021
@jleveque
Add sonic-ledd (Front-panel LED control daemon) (sonic-net#5)
bd7c310
JunhongMao added a commit to JunhongMao/sonic-utilities that referenced this pull request Sep 1, 2023
@JunhongMao
* [saidump]
2b43852 
•	Saidump for DNX-SAI sonic-net/sonic-buildimage#13561

Solution and modification:
To use the redis-db SAVE option to save the snapshot of DB each time and recover later, instead of looping through each entry in the table and saving it.

(1) Updated sonic-buildimage/build_debian.sh, to install Python library rdbtools into the host.
(2) Updated sonic-buildimage/src/sonic-sairedis/saidump/saidump.cpp, add a new option -r, which updates the rdbtools's output-JSON files' format.
(3) Add a new script file: files/scripts/saidump.sh, to do the below steps
  For each ASIC0, such as ASIC0,

  sonic-net#1. Save the Redis data.
  sudo sonic-db-cli -n asic$1 SAVE > /dev/null

  sonic-net#2. Move dump files to /var/run/redisX/
  docker exec database$1 sh -c "mv /var/lib/redis/dump.rdb /var/run/redis$1/"

  sonic-net#3. Run rdb command to convert the dump files into JSON files
  sudo python /usr/local/bin/rdb --command json  /var/run/redis$1/dump.rdb | sudo tee /var/run/redis$1/dump.json > /dev/null

  sonic-net#4. Run saidump -r to update the JSON files' format as same as the saidump before. Then we can get the saidump result in standard output.
  docker exec syncd$1 sh -c "saidump -r /var/run/redis$1/dump.json"

  sonic-net#5. clear
  sudo rm -f /var/run/redis$1/dump.rdb
  sudo rm -f /var/run/redis$1/dump.json

(4) Update sonic-buildimage/src/sonic-utilities/scripts/generate_dump, replace saidump with saidump.sh
mihirpat1 pushed a commit to mihirpat1/sonic-utilities that referenced this pull request Sep 15, 2023
@jleveque
Make all 'except' statements compatible with both Python 2 and Python…
ba614d3 
… 3 (sonic-net#5)
judyjoseph pushed a commit that referenced this pull request Nov 15, 2023
@JunhongMao
[VOQ][saidump] Modify generate_dump: replace save_saidump with save_s…
cd85569 
…aidump_by_route_size (#2972)

* * [saidump]
•	Saidump for DNX-SAI sonic-net/sonic-buildimage#13561

Solution and modification:
To use the redis-db SAVE option to save the snapshot of DB each time and recover later, instead of looping through each entry in the table and saving it.

(1) Updated sonic-buildimage/build_debian.sh, to install Python library rdbtools into the host.
(2) Updated sonic-buildimage/src/sonic-sairedis/saidump/saidump.cpp, add a new option -r, which updates the rdbtools's output-JSON files' format.
(3) Add a new script file: files/scripts/saidump.sh, to do the below steps
  For each ASIC0, such as ASIC0,

  #1. Save the Redis data.
  sudo sonic-db-cli -n asic$1 SAVE > /dev/null

  #2. Move dump files to /var/run/redisX/
  docker exec database$1 sh -c "mv /var/lib/redis/dump.rdb /var/run/redis$1/"

  #3. Run rdb command to convert the dump files into JSON files
  sudo python /usr/local/bin/rdb --command json  /var/run/redis$1/dump.rdb | sudo tee /var/run/redis$1/dump.json > /dev/null

  #4. Run saidump -r to update the JSON files' format as same as the saidump before. Then we can get the saidump result in standard output.
  docker exec syncd$1 sh -c "saidump -r /var/run/redis$1/dump.json"

  #5. clear
  sudo rm -f /var/run/redis$1/dump.rdb
  sudo rm -f /var/run/redis$1/dump.json

(4) Update sonic-buildimage/src/sonic-utilities/scripts/generate_dump, replace saidump with saidump.sh
* * [saidump]
•	Saidump for DNX-SAI sonic-net/sonic-buildimage#13561
StormLiangMS pushed a commit that referenced this pull request Nov 19, 2023
@JunhongMao @StormLiangMS
[VOQ][saidump] Modify generate_dump: replace save_saidump with save_s…
d9473c0 
…aidump_by_route_size (#2972)

* * [saidump]
•	Saidump for DNX-SAI sonic-net/sonic-buildimage#13561

Solution and modification:
To use the redis-db SAVE option to save the snapshot of DB each time and recover later, instead of looping through each entry in the table and saving it.

(1) Updated sonic-buildimage/build_debian.sh, to install Python library rdbtools into the host.
(2) Updated sonic-buildimage/src/sonic-sairedis/saidump/saidump.cpp, add a new option -r, which updates the rdbtools's output-JSON files' format.
(3) Add a new script file: files/scripts/saidump.sh, to do the below steps
  For each ASIC0, such as ASIC0,

  #1. Save the Redis data.
  sudo sonic-db-cli -n asic$1 SAVE > /dev/null

  #2. Move dump files to /var/run/redisX/
  docker exec database$1 sh -c "mv /var/lib/redis/dump.rdb /var/run/redis$1/"

  #3. Run rdb command to convert the dump files into JSON files
  sudo python /usr/local/bin/rdb --command json  /var/run/redis$1/dump.rdb | sudo tee /var/run/redis$1/dump.json > /dev/null

  #4. Run saidump -r to update the JSON files' format as same as the saidump before. Then we can get the saidump result in standard output.
  docker exec syncd$1 sh -c "saidump -r /var/run/redis$1/dump.json"

  #5. clear
  sudo rm -f /var/run/redis$1/dump.rdb
  sudo rm -f /var/run/redis$1/dump.json

(4) Update sonic-buildimage/src/sonic-utilities/scripts/generate_dump, replace saidump with saidump.sh
* * [saidump]
•	Saidump for DNX-SAI sonic-net/sonic-buildimage#13561
ashutosh-agrawal pushed a commit to ashutosh-agrawal/sonic-utilities that referenced this pull request Apr 18, 2025
@kellyyeh
Add unittest infrastructure (sonic-net#5)
4d19e13
nmoray pushed a commit to nmoray/sonic-utilities that referenced this pull request Jun 25, 2025
@JunhongMao @nmoray
[VOQ][saidump] Modify generate_dump: replace save_saidump with save_s…
e306f35 
…aidump_by_route_size (sonic-net#2972)

* * [saidump]
•	Saidump for DNX-SAI sonic-net/sonic-buildimage#13561

Solution and modification:
To use the redis-db SAVE option to save the snapshot of DB each time and recover later, instead of looping through each entry in the table and saving it.

(1) Updated sonic-buildimage/build_debian.sh, to install Python library rdbtools into the host.
(2) Updated sonic-buildimage/src/sonic-sairedis/saidump/saidump.cpp, add a new option -r, which updates the rdbtools's output-JSON files' format.
(3) Add a new script file: files/scripts/saidump.sh, to do the below steps
  For each ASIC0, such as ASIC0,

  sonic-net#1. Save the Redis data.
  sudo sonic-db-cli -n asic$1 SAVE > /dev/null

  sonic-net#2. Move dump files to /var/run/redisX/
  docker exec database$1 sh -c "mv /var/lib/redis/dump.rdb /var/run/redis$1/"

  sonic-net#3. Run rdb command to convert the dump files into JSON files
  sudo python /usr/local/bin/rdb --command json  /var/run/redis$1/dump.rdb | sudo tee /var/run/redis$1/dump.json > /dev/null

  sonic-net#4. Run saidump -r to update the JSON files' format as same as the saidump before. Then we can get the saidump result in standard output.
  docker exec syncd$1 sh -c "saidump -r /var/run/redis$1/dump.json"

  sonic-net#5. clear
  sudo rm -f /var/run/redis$1/dump.rdb
  sudo rm -f /var/run/redis$1/dump.json

(4) Update sonic-buildimage/src/sonic-utilities/scripts/generate_dump, replace saidump with saidump.sh
* * [saidump]
•	Saidump for DNX-SAI sonic-net/sonic-buildimage#13561
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lguohan lguohan lguohan requested changes

+1 more reviewer

@jleveque jleveque jleveque requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stcheng @lguohan @jleveque