Add port FEC BER show changes#3607
Merged
prgeor merged 5 commits intosonic-net:masterfrom Nov 25, 2024
Merged
Conversation
Signed-off-by: vincent ng <vincent.ng@arista.com>
Signed-off-by: vincent ng <vincent.ng@arista.com>
Signed-off-by: vincent ng <vincent.ng@arista.com>
Signed-off-by: vincent ng <vincent.ng@arista.com>
prgeor
reviewed
Nov 18, 2024
Contributor
prgeor
left a comment
prgeor
left a comment
There was a problem hiding this comment.
@vincentpcng can you please update the command reference doc with the new output?
https://github.com/sonic-net/sonic-utilities/blob/master/doc/Command-Reference.md
Signed-off-by: vincent ng <vincent.ng@arista.com>
Contributor
Author
|
Look like the Command-Reference.md were missing the cli "show interface counters fec-stats". I updated the Command-Reference.md to add the show interface counters fec-stats , including the pre and post FEC |
prgeor
approved these changes
Nov 19, 2024
Contributor
Author
|
Hi Prince,
Thanks for all the helps and support !
For the port FEC BER feature, we still have one PR pending for merge.
#3607
Thanks !
Vincent
From: Prince George ***@***.***>
Reply-To: sonic-net/sonic-utilities ***@***.***>
Date: Monday, November 18, 2024 at 10:10 PM
To: sonic-net/sonic-utilities ***@***.***>
Cc: vincentpcng ***@***.***>, Mention ***@***.***>
Subject: Re: [sonic-net/sonic-utilities] Add port FEC BER show changes (PR #3607)
@prgeor approved this pull request.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
nmoray
pushed a commit
to nmoray/sonic-utilities
that referenced
this pull request
Jun 25, 2025
* Add port FEC BER show changes Signed-off-by: vincent ng <vincent.ng@arista.com> * Add port FEC BER show changes Signed-off-by: vincent ng <vincent.ng@arista.com> * Add port FEC BER show changes Signed-off-by: vincent ng <vincent.ng@arista.com> * Add port FEC BER show changes Signed-off-by: vincent ng <vincent.ng@arista.com> * Add port FEC BER show changes Signed-off-by: vincent ng <vincent.ng@arista.com> --------- Signed-off-by: vincent ng <vincent.ng@arista.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
This is to add the utilities changes for the feature port FEC BER.
This change the cli output as describled in the HLD#1829, Port FEC BER
Two additonal PR(s) will address the swss ( sonic-swss) and the sonic-mgmt changes
How I did it
This is to add two additional column for the cli "show interface counters fec-stat".
The new new colums are FEC_PRE_BER FEC_POST_BER
How to verify it
using the following two cli, one can verify the output
(1) show interface counters fec-stat
(2) portstat -f
Previous command output (if the output of a command-line utility has changed)
portstat -f
IFACE STATE FEC_CORR FEC_UNCORR FEC_SYMBOL_ERR
New command output (if the output of a command-line utility has changed)
portstat -f
IFACE STATE FEC_CORR FEC_UNCORR FEC_SYMBOL_ERR FEC_PRE_BER FEC_POST_BER