Add port FEC BER feature swss#3363
Merged
prsunny merged 2 commits intosonic-net:masterfrom Nov 22, 2024
Merged
Conversation
Signed-off-by: vincent ng <[email protected]>
vincentpcng
changed the title
prgeor
reviewed
Nov 18, 2024
prgeor
reviewed
Nov 18, 2024
prgeor
approved these changes
Nov 18, 2024
prgeor
approved these changes
Nov 19, 2024
Contributor
|
@prsunny can you merge? |
Collaborator
|
is there a corresponding CLI change? |
Contributor
Author
Yes the existing CLI "show interface counters fec-stats" were enhanced to add additional column show command changes: and mgmt changed: |
github-actions bot
pushed a commit
to bradh352/sonic-swss
that referenced
this pull request
Nov 23, 2024
What I did This is to add the swss changes for the feature port FEC BER. It modify the port_rates.lua script to compute the BER and stored them in the DB . Two additonal PR(s) will address the cli ( sonic-utilities) and the sonic-mgmt changes Why I did it The HLD for this feature is HLD#1829 How I verified it We verify the counters internally (1) verify when link has correctable FEC errors, the BER were calcuated accordingly (2) verify 400G with 4x100 and the BER , four serdes with 100G rate (3) run a redis-script to polling the DB counters and verify the calculation (4) stop polling manually modify the uncorrectable counter and verify the cli display and calculation
bradh352
pushed a commit
to bradh352/sonic-swss
that referenced
this pull request
Dec 4, 2024
What I did This is to add the swss changes for the feature port FEC BER. It modify the port_rates.lua script to compute the BER and stored them in the DB . Two additonal PR(s) will address the cli ( sonic-utilities) and the sonic-mgmt changes Why I did it The HLD for this feature is HLD#1829 How I verified it We verify the counters internally (1) verify when link has correctable FEC errors, the BER were calcuated accordingly (2) verify 400G with 4x100 and the BER , four serdes with 100G rate (3) run a redis-script to polling the DB counters and verify the calculation (4) stop polling manually modify the uncorrectable counter and verify the cli display and calculation
bradh352
pushed a commit
to bradh352/sonic-swss
that referenced
this pull request
Dec 4, 2024
What I did This is to add the swss changes for the feature port FEC BER. It modify the port_rates.lua script to compute the BER and stored them in the DB . Two additonal PR(s) will address the cli ( sonic-utilities) and the sonic-mgmt changes Why I did it The HLD for this feature is HLD#1829 How I verified it We verify the counters internally (1) verify when link has correctable FEC errors, the BER were calcuated accordingly (2) verify 400G with 4x100 and the BER , four serdes with 100G rate (3) run a redis-script to polling the DB counters and verify the calculation (4) stop polling manually modify the uncorrectable counter and verify the cli display and calculation
divyachandralekha
pushed a commit
to divyachandralekha/sonic-swss
that referenced
this pull request
Dec 12, 2024
What I did This is to add the swss changes for the feature port FEC BER. It modify the port_rates.lua script to compute the BER and stored them in the DB . Two additonal PR(s) will address the cli ( sonic-utilities) and the sonic-mgmt changes Why I did it The HLD for this feature is HLD#1829 How I verified it We verify the counters internally (1) verify when link has correctable FEC errors, the BER were calcuated accordingly (2) verify 400G with 4x100 and the BER , four serdes with 100G rate (3) run a redis-script to polling the DB counters and verify the calculation (4) stop polling manually modify the uncorrectable counter and verify the cli display and calculation
divyachandralekha
pushed a commit
to divyachandralekha/sonic-swss
that referenced
this pull request
Dec 12, 2024
What I did This is to add the swss changes for the feature port FEC BER. It modify the port_rates.lua script to compute the BER and stored them in the DB . Two additonal PR(s) will address the cli ( sonic-utilities) and the sonic-mgmt changes Why I did it The HLD for this feature is HLD#1829 How I verified it We verify the counters internally (1) verify when link has correctable FEC errors, the BER were calcuated accordingly (2) verify 400G with 4x100 and the BER , four serdes with 100G rate (3) run a redis-script to polling the DB counters and verify the calculation (4) stop polling manually modify the uncorrectable counter and verify the cli display and calculation
shiraez
pushed a commit
to Marvell-switching/sonic-swss
that referenced
this pull request
Feb 17, 2025
What I did This is to add the swss changes for the feature port FEC BER. It modify the port_rates.lua script to compute the BER and stored them in the DB . Two additonal PR(s) will address the cli ( sonic-utilities) and the sonic-mgmt changes Why I did it The HLD for this feature is HLD#1829 How I verified it We verify the counters internally (1) verify when link has correctable FEC errors, the BER were calcuated accordingly (2) verify 400G with 4x100 and the BER , four serdes with 100G rate (3) run a redis-script to polling the DB counters and verify the calculation (4) stop polling manually modify the uncorrectable counter and verify the cli display and calculation
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
What I did This is to add the swss changes for the feature port FEC BER. It modify the port_rates.lua script to compute the BER and stored them in the DB . Two additonal PR(s) will address the cli ( sonic-utilities) and the sonic-mgmt changes Why I did it The HLD for this feature is HLD#1829 How I verified it We verify the counters internally (1) verify when link has correctable FEC errors, the BER were calcuated accordingly (2) verify 400G with 4x100 and the BER , four serdes with 100G rate (3) run a redis-script to polling the DB counters and verify the calculation (4) stop polling manually modify the uncorrectable counter and verify the cli display and calculation
baorliu
pushed a commit
to baorliu/sonic-swss
that referenced
this pull request
Feb 23, 2026
What I did This is to add the swss changes for the feature port FEC BER. It modify the port_rates.lua script to compute the BER and stored them in the DB . Two additonal PR(s) will address the cli ( sonic-utilities) and the sonic-mgmt changes Why I did it The HLD for this feature is HLD#1829 How I verified it We verify the counters internally (1) verify when link has correctable FEC errors, the BER were calcuated accordingly (2) verify 400G with 4x100 and the BER , four serdes with 100G rate (3) run a redis-script to polling the DB counters and verify the calculation (4) stop polling manually modify the uncorrectable counter and verify the cli display and calculation Signed-off-by: Baorong Liu <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
This is to add the swss changes for the feature port FEC BER.
It modify the port_rates.lua script to compute the BER and stored them in the DB .
Two additonal PR(s) will address the cli ( sonic-utilities) and the sonic-mgmt changes
Why I did it
The HLD for this feature is HLD#1829
How I verified it
We verify the counters internally
(1) verify when link has correctable FEC errors, the BER were calcuated accordingly
(2) verify 400G with 4x100 and the BER , four serdes with 100G rate
(3) run a redis-script to polling the DB counters and verify the calculation
(4) stop polling manually modify the uncorrectable counter and verify the cli display and calculation
Details if related