Skip to content

[NTP] When mgmtvrf is enabled, the NTP vrf should be changed to "mgmt" #3456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
irene-pan1202 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[NTP] When mgmtvrf is enabled, the NTP vrf should be changed to "mgmt" #3456

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions config/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3460,6 +3460,7 @@ def vrf_add_management_vrf(config_db):
return None
try:
config_db.mod_entry('MGMT_VRF_CONFIG', "vrf_global", {"mgmtVrfEnabled": "true"})
config_db.mod_entry('NTP', "global", {"vrf": "mgmt"})
Copy link
Copy Markdown

@nmoray nmoray Dec 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you modifying NTP global config table while updating MGMT_VRF_CONFIG table? IMO, Better to have new CLI to set the VRF in NTP Global table so that user will have the flexibility to use the NTP in non-default VRF in presence of MGMT-VRF.

except ValueError as e:
ctx = click.get_current_context()
ctx.fail("Invalid ConfigDB. Error: {}".format(e))
Expand All @@ -3474,6 +3475,7 @@ def vrf_delete_management_vrf(config_db):
return None
try:
config_db.mod_entry('MGMT_VRF_CONFIG', "vrf_global", {"mgmtVrfEnabled": "false"})
config_db.mod_entry('NTP', "global", {"vrf": "default"})
except ValueError as e:
ctx = click.get_current_context()
ctx.fail("Invalid ConfigDB. Error: {}".format(e))
Expand Down