[NTP] When mgmtvrf is enabled, the NTP vrf should be changed to "mgmt"#3456
Open
irene-pan1202 wants to merge 1 commit intosonic-net:masterfrom
Open
[NTP] When mgmtvrf is enabled, the NTP vrf should be changed to "mgmt"#3456irene-pan1202 wants to merge 1 commit intosonic-net:masterfrom
irene-pan1202 wants to merge 1 commit intosonic-net:masterfrom
Conversation
Signed-off-by: irene_pan irene_pan@edge-core.com
nmoray
reviewed
Dec 2, 2024
| return None | ||
| try: | ||
| config_db.mod_entry('MGMT_VRF_CONFIG', "vrf_global", {"mgmtVrfEnabled": "true"}) | ||
| config_db.mod_entry('NTP', "global", {"vrf": "mgmt"}) |
There was a problem hiding this comment.
Why are you modifying NTP global config table while updating MGMT_VRF_CONFIG table? IMO, Better to have new CLI to set the VRF in NTP Global table so that user will have the flexibility to use the NTP in non-default VRF in presence of MGMT-VRF.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
#15058
Configure NTP global parameters, and specify the NTP vrf as "default".
The NTP vrf does not change to "mgmt" when mgmtvrf is enabled, causing NTP create socket to fail.
When mgmtvrf is enabled, the NTP vrf should be changed to "mgmt".
How I did it
How to verify it
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)