Validate interface name length in CLI#3397
Closed
arfeigin wants to merge 8 commits intosonic-net:masterfrom
Closed
Validate interface name length in CLI#3397arfeigin wants to merge 8 commits intosonic-net:masterfrom
arfeigin wants to merge 8 commits intosonic-net:masterfrom
Conversation
This was referenced Jul 3, 2024
arfeigin
force-pushed
the
master_validate_interface_name_length-new
branch
from
a19e82d to
1d8ac45
Compare
arfeigin
force-pushed
the
master_validate_interface_name_length-new
branch
from
1d8ac45 to
942edde
Compare
Contributor
Author
|
Checkers fail as sonic-net/sonic-swss-common#889 should be merged first so it will compile. |
Contributor
Author
|
@prsunny Can you please help reviewing this and the attached PRs? |
nazariig
approved these changes
Jul 29, 2024
Collaborator
|
@prsunny , Can you please approve this PR ? |
qiluo-msft
reviewed
Aug 26, 2024
qiluo-msft
reviewed
Aug 26, 2024
qiluo-msft
reviewed
Aug 26, 2024
qiluo-msft
reviewed
Aug 26, 2024
11 tasks
qiluo-msft
approved these changes
Sep 9, 2024
prsunny
approved these changes
Sep 13, 2024
Contributor
|
/azp run Azure.sonic-utilities |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Oct 17, 2024
Contributor
|
@qiluo-msft @prsunny Please review #3580 |
qiluo-msft
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Nov 22, 2024
This PR is accompanied by sonic-net/sonic-swss-common#889 and sonic-net/sonic-utilities#3397 Why I did it Validate interface name length does not exceed the limitation of IFNAMSIZ to align to kernel restrictions. How I did it Add validation checks in the relevant yang-model definitions for the following interface types: vxlan vlan vrf loopback subinterface portchannel How to verify it UT added
VladimirKuk
pushed a commit
to Marvell-switching/sonic-buildimage
that referenced
this pull request
Jan 21, 2025
This PR is accompanied by sonic-net/sonic-swss-common#889 and sonic-net/sonic-utilities#3397 Why I did it Validate interface name length does not exceed the limitation of IFNAMSIZ to align to kernel restrictions. How I did it Add validation checks in the relevant yang-model definitions for the following interface types: vxlan vlan vrf loopback subinterface portchannel How to verify it UT added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is accompanied by sonic-net/sonic-swss-common#889 and sonic-net/sonic-buildimage#20108
What I did
Validate interface name length does not exceed the limitation of IFNAMSIZ to align to kernel restrictions.
How I did it
Add validation checks in the relevant config functions for the following interface types:
vxlan
vlan
vrf
loopback
subinterface
portchannel
How to verify it
UT tests added
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)